From: Max Reitz <mreitz@redhat.com>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Kevin Wolf <kwolf@redhat.com>
Cc: Tu Bo <tubo@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] qemu-iotests: tests: do not set unused tmp variable
Date: Tue, 12 Apr 2016 19:14:32 +0200 [thread overview]
Message-ID: <570D2CF8.3010403@redhat.com> (raw)
In-Reply-To: <1460472980-26319-4-git-send-email-silbe@linux.vnet.ibm.com>
[-- Attachment #1.1: Type: text/plain, Size: 4295 bytes --]
On 12.04.2016 16:56, Sascha Silbe wrote:
> The previous commit removed the last usage of ${tmp} inside the tests
> themselves; the only remaining users are sourced by check. So we can now
> drop this variable from the tests.
>
> Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
> Reviewed-by: Bo Tu <tubo@linux.vnet.ibm.com>
> ---
> tests/qemu-iotests/001 | 1 -
> tests/qemu-iotests/002 | 1 -
> tests/qemu-iotests/003 | 1 -
> tests/qemu-iotests/004 | 1 -
> tests/qemu-iotests/005 | 1 -
> tests/qemu-iotests/007 | 1 -
> tests/qemu-iotests/008 | 1 -
> tests/qemu-iotests/009 | 1 -
> tests/qemu-iotests/010 | 1 -
> tests/qemu-iotests/011 | 1 -
> tests/qemu-iotests/012 | 1 -
> tests/qemu-iotests/013 | 1 -
> tests/qemu-iotests/014 | 1 -
> tests/qemu-iotests/015 | 1 -
> tests/qemu-iotests/017 | 1 -
> tests/qemu-iotests/018 | 1 -
> tests/qemu-iotests/019 | 1 -
> tests/qemu-iotests/020 | 1 -
> tests/qemu-iotests/021 | 1 -
> tests/qemu-iotests/022 | 1 -
> tests/qemu-iotests/023 | 1 -
> tests/qemu-iotests/024 | 1 -
> tests/qemu-iotests/025 | 1 -
> tests/qemu-iotests/026 | 1 -
> tests/qemu-iotests/027 | 1 -
> tests/qemu-iotests/028 | 1 -
> tests/qemu-iotests/029 | 1 -
> tests/qemu-iotests/031 | 1 -
> tests/qemu-iotests/032 | 1 -
> tests/qemu-iotests/033 | 1 -
> tests/qemu-iotests/034 | 1 -
> tests/qemu-iotests/035 | 1 -
> tests/qemu-iotests/036 | 1 -
> tests/qemu-iotests/037 | 1 -
> tests/qemu-iotests/038 | 1 -
> tests/qemu-iotests/039 | 1 -
> tests/qemu-iotests/042 | 1 -
> tests/qemu-iotests/043 | 1 -
> tests/qemu-iotests/046 | 1 -
> tests/qemu-iotests/047 | 1 -
> tests/qemu-iotests/049 | 1 -
> tests/qemu-iotests/050 | 1 -
> tests/qemu-iotests/051 | 1 -
> tests/qemu-iotests/052 | 1 -
> tests/qemu-iotests/053 | 1 -
> tests/qemu-iotests/054 | 1 -
> tests/qemu-iotests/058 | 1 -
> tests/qemu-iotests/059 | 1 -
> tests/qemu-iotests/060 | 1 -
> tests/qemu-iotests/061 | 1 -
> tests/qemu-iotests/062 | 1 -
> tests/qemu-iotests/063 | 1 -
> tests/qemu-iotests/064 | 1 -
> tests/qemu-iotests/066 | 1 -
> tests/qemu-iotests/067 | 1 -
> tests/qemu-iotests/068 | 1 -
> tests/qemu-iotests/069 | 1 -
> tests/qemu-iotests/070 | 1 -
> tests/qemu-iotests/071 | 1 -
> tests/qemu-iotests/072 | 1 -
> tests/qemu-iotests/073 | 1 -
> tests/qemu-iotests/075 | 1 -
> tests/qemu-iotests/076 | 1 -
> tests/qemu-iotests/077 | 1 -
> tests/qemu-iotests/078 | 1 -
> tests/qemu-iotests/079 | 1 -
> tests/qemu-iotests/080 | 1 -
> tests/qemu-iotests/081 | 1 -
> tests/qemu-iotests/082 | 1 -
> tests/qemu-iotests/083 | 1 -
> tests/qemu-iotests/084 | 1 -
> tests/qemu-iotests/086 | 1 -
> tests/qemu-iotests/087 | 1 -
> tests/qemu-iotests/088 | 1 -
> tests/qemu-iotests/089 | 1 -
> tests/qemu-iotests/090 | 1 -
> tests/qemu-iotests/092 | 1 -
> tests/qemu-iotests/094 | 1 -
> tests/qemu-iotests/097 | 1 -
> tests/qemu-iotests/098 | 1 -
> tests/qemu-iotests/099 | 1 -
> tests/qemu-iotests/100 | 1 -
> tests/qemu-iotests/101 | 1 -
> tests/qemu-iotests/102 | 1 -
> tests/qemu-iotests/103 | 1 -
> tests/qemu-iotests/104 | 1 -
> tests/qemu-iotests/105 | 1 -
> tests/qemu-iotests/107 | 1 -
> tests/qemu-iotests/108 | 1 -
> tests/qemu-iotests/109 | 1 -
> tests/qemu-iotests/110 | 1 -
> tests/qemu-iotests/111 | 1 -
> tests/qemu-iotests/112 | 1 -
> tests/qemu-iotests/113 | 1 -
> tests/qemu-iotests/114 | 1 -
> tests/qemu-iotests/115 | 1 -
> tests/qemu-iotests/116 | 1 -
> tests/qemu-iotests/117 | 1 -
> tests/qemu-iotests/119 | 1 -
> tests/qemu-iotests/120 | 1 -
> tests/qemu-iotests/121 | 1 -
> tests/qemu-iotests/122 | 1 -
> tests/qemu-iotests/123 | 1 -
> tests/qemu-iotests/128 | 1 -
> tests/qemu-iotests/130 | 1 -
> tests/qemu-iotests/131 | 1 -
> tests/qemu-iotests/133 | 1 -
> tests/qemu-iotests/134 | 1 -
> tests/qemu-iotests/135 | 1 -
> tests/qemu-iotests/137 | 1 -
> tests/qemu-iotests/138 | 1 -
> tests/qemu-iotests/140 | 1 -
> tests/qemu-iotests/141 | 1 -
> tests/qemu-iotests/142 | 1 -
> tests/qemu-iotests/143 | 1 -
> tests/qemu-iotests/145 | 1 -
> tests/qemu-iotests/150 | 1 -
> 117 files changed, 117 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-12 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 14:56 [Qemu-devel] [PATCH for-2.6 0/4] qemu-iotests: don't use /tmp Sascha Silbe
2016-04-12 14:56 ` [Qemu-devel] [PATCH 1/4] qemu-iotests: drop unused _within_tolerance() filter Sascha Silbe
2016-04-12 16:57 ` Max Reitz
2016-04-12 14:56 ` [Qemu-devel] [PATCH 2/4] qemu-iotests: common.rc: drop unused _do() Sascha Silbe
2016-04-12 17:08 ` Max Reitz
2016-04-12 14:56 ` [Qemu-devel] [PATCH 3/4] qemu-iotests: tests: do not set unused tmp variable Sascha Silbe
2016-04-12 17:14 ` Max Reitz [this message]
2016-04-12 14:56 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: place valgrind log file in scratch dir Sascha Silbe
2016-04-12 17:19 ` Max Reitz
2016-04-12 17:32 ` [Qemu-devel] [PATCH for-2.6 0/4] qemu-iotests: don't use /tmp Max Reitz
2016-04-14 11:41 ` Sascha Silbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570D2CF8.3010403@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
--cc=tubo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).