From: Paolo Bonzini <pbonzini@redhat.com>
To: Nutan Shinde <nutanshinde1992@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void
Date: Tue, 12 Apr 2016 23:23:59 +0200 [thread overview]
Message-ID: <570D676F.3060600@redhat.com> (raw)
In-Reply-To: <CADyday1ZbVN2WM2WLoZoD3=X9ZD3Au5Duh=gMa2Buj3tV3auBw@mail.gmail.com>
On 12/04/2016 20:17, Nutan Shinde wrote:
>
> -static int console_exit(SCLPEvent *event)
> +static console_exit(SCLPEvent *event)
> {
> - return 0;
This patch doesn't even compile:
CC hw/char/sclpconsole.o
/home/pbonzini/work/upstream/qemu/hw/char/sclpconsole.c:245:8: error: return type defaults to ‘int’ [-Werror=implicit-int]
static console_exit(SCLPEvent *event)
^
cc1: all warnings being treated as errors
Paolo
next prev parent reply other threads:[~2016-04-12 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1460484949-5798-1-git-send-email-nutanshinde1992@gmail.com>
2016-04-12 18:17 ` [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void Nutan Shinde
2016-04-12 21:23 ` Paolo Bonzini [this message]
2016-04-13 6:33 ` Markus Armbruster
2016-04-13 7:38 ` Paolo Bonzini
2016-04-13 11:29 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570D676F.3060600@redhat.com \
--to=pbonzini@redhat.com \
--cc=nutanshinde1992@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).