From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56938)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aq5n7-00026Z-Sg
	for qemu-devel@nongnu.org; Tue, 12 Apr 2016 17:24:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aq5n3-0002Hj-Pd
	for qemu-devel@nongnu.org; Tue, 12 Apr 2016 17:24:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47592)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aq5n3-0002Hb-K9
	for qemu-devel@nongnu.org; Tue, 12 Apr 2016 17:24:05 -0400
References: <1460484949-5798-1-git-send-email-nutanshinde1992@gmail.com>
	<CADyday1ZbVN2WM2WLoZoD3=X9ZD3Au5Duh=gMa2Buj3tV3auBw@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <570D676F.3060600@redhat.com>
Date: Tue, 12 Apr 2016 23:23:59 +0200
MIME-Version: 1.0
In-Reply-To: <CADyday1ZbVN2WM2WLoZoD3=X9ZD3Au5Duh=gMa2Buj3tV3auBw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of
 functions that are named *_exit or *_exitfn in hw/char from int to void
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nutan Shinde <nutanshinde1992@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>



On 12/04/2016 20:17, Nutan Shinde wrote:
>=20
> -static int console_exit(SCLPEvent *event)
> +static console_exit(SCLPEvent *event)
>  {
> -    return 0;

This patch doesn't even compile:

  CC    hw/char/sclpconsole.o
/home/pbonzini/work/upstream/qemu/hw/char/sclpconsole.c:245:8: error: ret=
urn type defaults to =E2=80=98int=E2=80=99 [-Werror=3Dimplicit-int]
 static console_exit(SCLPEvent *event)
        ^
cc1: all warnings being treated as errors


Paolo