* [Qemu-devel] [PATCH] vl: chanage runstate only if new state is different from current state
@ 2016-04-13 9:27 Li Zhijian
2016-04-13 11:57 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Li Zhijian @ 2016-04-13 9:27 UTC (permalink / raw)
To: pbonzini, qemu-devel; +Cc: Li Zhijian
Previously, qemu will abort at following scenario:
(qemu) stop
(qemu) system_reset
(qemu) system_reset
(qemu) 2016-04-13T20:54:38.979158Z qemu-system-x86_64: invalid runstate transition: 'prelaunch' -> 'prelaunch'
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
vl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/vl.c b/vl.c
index 9df534f..039a353 100644
--- a/vl.c
+++ b/vl.c
@@ -692,6 +692,10 @@ void runstate_set(RunState new_state)
{
assert(new_state < RUN_STATE__MAX);
+ if (current_run_state == new_state) {
+ return ;
+ }
+
if (!runstate_valid_transitions[current_run_state][new_state]) {
error_report("invalid runstate transition: '%s' -> '%s'",
RunState_lookup[current_run_state],
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vl: chanage runstate only if new state is different from current state
2016-04-13 9:27 [Qemu-devel] [PATCH] vl: chanage runstate only if new state is different from current state Li Zhijian
@ 2016-04-13 11:57 ` Paolo Bonzini
2016-04-14 3:28 ` Li Zhijian
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2016-04-13 11:57 UTC (permalink / raw)
To: Li Zhijian, qemu-devel, Gerd Hoffmann, Juan Quintela,
Peter Maydell
On 13/04/2016 11:27, Li Zhijian wrote:
> Previously, qemu will abort at following scenario:
> (qemu) stop
> (qemu) system_reset
> (qemu) system_reset
> (qemu) 2016-04-13T20:54:38.979158Z qemu-system-x86_64: invalid runstate transition: 'prelaunch' -> 'prelaunch'
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Can someone I've CCed help this patch, since I won't be able to send a
pull request?
Paolo
> vl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 9df534f..039a353 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -692,6 +692,10 @@ void runstate_set(RunState new_state)
> {
> assert(new_state < RUN_STATE__MAX);
>
> + if (current_run_state == new_state) {
> + return ;
> + }
> +
> if (!runstate_valid_transitions[current_run_state][new_state]) {
> error_report("invalid runstate transition: '%s' -> '%s'",
> RunState_lookup[current_run_state],
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vl: chanage runstate only if new state is different from current state
2016-04-13 11:57 ` Paolo Bonzini
@ 2016-04-14 3:28 ` Li Zhijian
0 siblings, 0 replies; 3+ messages in thread
From: Li Zhijian @ 2016-04-14 3:28 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel, Gerd Hoffmann, Juan Quintela,
Peter Maydell
I send V2 with minor fix
- fix patch title typo 'chanage' -> 'change'
- coding sytle: 'return ;' -> 'return;'
- add Acked tag
pls review the V2.
Best regards
Li Zhijian
On 04/13/2016 07:57 PM, Paolo Bonzini wrote:
> On 13/04/2016 11:27, Li Zhijian wrote:
>> Previously, qemu will abort at following scenario:
>> (qemu) stop
>> (qemu) system_reset
>> (qemu) system_reset
>> (qemu) 2016-04-13T20:54:38.979158Z qemu-system-x86_64: invalid runstate transition: 'prelaunch' -> 'prelaunch'
>>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Can someone I've CCed help this patch, since I won't be able to send a
> pull request?
>
> Paolo
>
>> vl.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 9df534f..039a353 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -692,6 +692,10 @@ void runstate_set(RunState new_state)
>> {
>> assert(new_state < RUN_STATE__MAX);
>>
>> + if (current_run_state == new_state) {
>> + return ;
>> + }
>> +
>> if (!runstate_valid_transitions[current_run_state][new_state]) {
>> error_report("invalid runstate transition: '%s' -> '%s'",
>> RunState_lookup[current_run_state],
>>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-14 3:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-13 9:27 [Qemu-devel] [PATCH] vl: chanage runstate only if new state is different from current state Li Zhijian
2016-04-13 11:57 ` Paolo Bonzini
2016-04-14 3:28 ` Li Zhijian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).