From: Leon Alrae <leon.alrae@imgtec.com>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
qemu-devel@nongnu.org
Cc: proljc@gmail.com, kbastian@mail.uni-paderborn.de,
mark.cave-ayland@ilande.co.uk, agraf@suse.de,
blauwirbel@gmail.com, jcmvbkbc@gmail.com,
aleksandar.markovic@imgtec.com, qemu-arm@nongnu.org,
qemu-ppc@nongnu.org, petar.jovanovic@imgtec.com,
pbonzini@redhat.com, miodrag.dinic@imgtec.com,
edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, afaerber@suse.de,
aurelien@aurel32.net, rth@twiddle.net, maciej.rozycki@imgtec.com
Subject: Re: [Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit
Date: Wed, 13 Apr 2016 13:11:01 +0100 [thread overview]
Message-ID: <570E3755.4060608@imgtec.com> (raw)
In-Reply-To: <1460465891-6142-2-git-send-email-aleksandar.markovic@rt-rk.com>
On 12/04/16 13:58, Aleksandar Markovic wrote:
> @@ -322,14 +327,14 @@ int float32_is_quiet_nan( float32 a_ )
> | NaN; otherwise returns 0.
> *----------------------------------------------------------------------------*/
>
> -int float32_is_signaling_nan( float32 a_ )
> +int float32_is_signaling_nan( float32 a_, float_status *status )
> {
> uint32_t a = float32_val(a_);
> -#if SNAN_BIT_IS_ONE
> - return ((uint32_t)(a << 1) >= 0xff800000);
> -#else
> - return ( ( ( a>>22 ) & 0x1FF ) == 0x1FE ) && ( a & 0x003FFFFF );
> -#endif
> + if (status->snan_bit_is_one) {
> + return ((uint32_t)(a << 1) >= 0xff800000);
> + } else {
> + return ( ( ( a>>22 ) & 0x1FF ) == 0x1FE ) && ( a & 0x003FFFFF );
> + }
Please correct the style while touching the lines.
Thanks,
Leon
next prev parent reply other threads:[~2016-04-13 12:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 12:58 [Qemu-devel] [PATCH v4 0/9] target-mips: Initiate IEEE 754-2008 support Aleksandar Markovic
2016-04-12 12:58 ` [Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit Aleksandar Markovic
2016-04-12 18:45 ` Eduardo Habkost
2016-04-13 18:41 ` Aleksandar Markovic
2016-04-13 19:04 ` Eduardo Habkost
2016-04-13 12:11 ` Leon Alrae [this message]
2016-04-14 15:31 ` Leon Alrae
2016-04-15 8:48 ` Aleksandar Markovic
2016-04-15 10:41 ` Leon Alrae
2016-04-15 11:38 ` Aleksandar Markovic
2016-04-17 18:21 ` Aleksandar Markovic
2016-04-12 12:58 ` [Qemu-devel] [PATCH v4 2/9] softfloat: For Mips only, correct default NaN values Aleksandar Markovic
2016-04-13 12:23 ` Leon Alrae
2016-04-12 12:58 ` [Qemu-devel] [PATCH v4 3/9] softfloat: For Mips only, correct order in pickNaNMulAdd() Aleksandar Markovic
2016-04-13 12:47 ` Leon Alrae
2016-04-13 13:53 ` Aleksandar Markovic
2016-04-12 12:58 ` [Qemu-devel] [PATCH v4 4/9] softfloat: Clean up hex constants capitalization in softfloat-specialize.h Aleksandar Markovic
2016-04-12 12:58 ` [Qemu-devel] [PATCH v4 5/9] softfloat: Clean up white spaces " Aleksandar Markovic
2016-04-12 12:58 ` [Qemu-devel] [PATCH v4 6/9] target-mips: Activate IEEE 274-2008 support Aleksandar Markovic
2016-04-12 12:58 ` [Qemu-devel] [PATCH v4 7/9] target-mips: Add abs2008 flavor of <ABS|NEG>.<S|D> Aleksandar Markovic
2016-04-14 10:52 ` Leon Alrae
2016-04-12 12:58 ` [Qemu-devel] [PATCH v4 8/9] target-mips: Add nan2008 flavor of <CEIL|CVT|FLOOR|ROUND|TRUNC>.<L|W>.<S|D> Aleksandar Markovic
2016-04-12 12:58 ` [Qemu-devel] [PATCH v4 9/9] target-mips: Clean up order of helpers for CVT.<L|W>.<S|D> Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E3755.4060608@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aleksandar.markovic@imgtec.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=maciej.rozycki@imgtec.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=miodrag.dinic@imgtec.com \
--cc=pbonzini@redhat.com \
--cc=petar.jovanovic@imgtec.com \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).