From: Tom Hanson <thomas.hanson@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] best way to implement emulation of AArch64 tagged addresses
Date: Wed, 13 Apr 2016 07:36:15 -0600 [thread overview]
Message-ID: <570E4B4F.4030304@linaro.org> (raw)
In-Reply-To: <CAA8zJ3D-J8SnXh-oM1qn3mezdP6-ugb9hn303mA=QmWHafHhnw@mail.gmail.com>
On 04/11/2016 06:58 AM, Thomas Hanson wrote:
> Ah, true.
>
> On 9 April 2016 at 09:57, Richard Henderson <rth@twiddle.net
> <mailto:rth@twiddle.net>> wrote:
>
> On 04/08/2016 05:29 PM, Thomas Hanson wrote:
>
> Looking at tcg_out_tlb_load():
> If I'm reading the pseudo-assembler of the function names
> correctly, it looks
> like in the i386 code we're already masking the address being
> checked:
> tgen_arithi(s, ARITH_AND + trexw, r1, TARGET_PAGE_MASK |
> (aligned ? s_mask
> : 0), 0);
> where TARGET_PAGE_MASK is a simple all-1's mask in the
> appropriate upper bits.
>
> Can we just poke some 0's into that mask in the tag locations?
>
>
> No, because we'd no longer have a sign-extended 32-bit value, as
> fits in that immediate operand field. To load the constant you're
> asking for, we'd need a 64-bit move insn and another register.
>
>
> r~
>
>
[Sorry for the previous top post(s). I've switched email clients...]
So, is the consensus that it's not worth adding an instruction to the
fast path to avoid kicking out TLB entries with non-matching tags?
Or is this still under consideration?
next prev parent reply other threads:[~2016-04-13 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 15:51 [Qemu-devel] best way to implement emulation of AArch64 tagged addresses Peter Maydell
2016-04-04 16:28 ` Richard Henderson
2016-04-04 16:31 ` Peter Maydell
2016-04-04 17:56 ` Richard Henderson
2016-04-08 17:20 ` Tom Hanson
2016-04-08 18:06 ` Peter Maydell
2016-04-08 18:10 ` Richard Henderson
2016-04-09 0:29 ` Thomas Hanson
2016-04-09 15:57 ` Richard Henderson
2016-04-11 12:58 ` Thomas Hanson
2016-04-13 13:36 ` Tom Hanson [this message]
2016-04-04 16:35 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E4B4F.4030304@linaro.org \
--to=thomas.hanson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).