* [Qemu-devel] [PATCH] accel: make configure_accelerator return void
@ 2016-03-15 10:07 Wei Jiangang
2016-04-14 3:19 ` Wei, Jiangang
0 siblings, 1 reply; 4+ messages in thread
From: Wei Jiangang @ 2016-03-15 10:07 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell, Wei Jiangang
Return the negated value of accel_initialised is meaningless,
and the caller vl doesn't check it.
Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
---
accel.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/accel.c b/accel.c
index 0510b90..403eb5e 100644
--- a/accel.c
+++ b/accel.c
@@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms)
return ret;
}
-int configure_accelerator(MachineState *ms)
+void configure_accelerator(MachineState *ms)
{
const char *p;
char buf[10];
@@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms)
if (init_failed) {
fprintf(stderr, "Back to %s accelerator.\n", acc->name);
}
-
- return !accel_initialised;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] accel: make configure_accelerator return void
2016-03-15 10:07 [Qemu-devel] [PATCH] accel: make configure_accelerator return void Wei Jiangang
@ 2016-04-14 3:19 ` Wei, Jiangang
2016-04-14 3:34 ` Changlong Xie
0 siblings, 1 reply; 4+ messages in thread
From: Wei, Jiangang @ 2016-04-14 3:19 UTC (permalink / raw)
To: qemu-devel@nongnu.org; +Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org
ping...
Any comments?
On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
> Return the negated value of accel_initialised is meaningless,
> and the caller vl doesn't check it.
>
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
> accel.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/accel.c b/accel.c
> index 0510b90..403eb5e 100644
> --- a/accel.c
> +++ b/accel.c
> @@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms)
> return ret;
> }
>
> -int configure_accelerator(MachineState *ms)
> +void configure_accelerator(MachineState *ms)
> {
> const char *p;
> char buf[10];
> @@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms)
> if (init_failed) {
> fprintf(stderr, "Back to %s accelerator.\n", acc->name);
> }
> -
> - return !accel_initialised;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] accel: make configure_accelerator return void
2016-04-14 3:19 ` Wei, Jiangang
@ 2016-04-14 3:34 ` Changlong Xie
2016-04-14 3:53 ` Wei, Jiangang
0 siblings, 1 reply; 4+ messages in thread
From: Changlong Xie @ 2016-04-14 3:34 UTC (permalink / raw)
To: Wei, Jiangang, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org
On 04/14/2016 11:19 AM, Wei, Jiangang wrote:
> ping...
> Any comments?
> On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
>> Return the negated value of accel_initialised is meaningless,
>> and the caller vl doesn't check it.
>>
>> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
>> ---
>> accel.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/accel.c b/accel.c
>> index 0510b90..403eb5e 100644
>> --- a/accel.c
>> +++ b/accel.c
>> @@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms)
>> return ret;
>> }
>>
>> -int configure_accelerator(MachineState *ms)
>> +void configure_accelerator(MachineState *ms)
>> {
>> const char *p;
>> char buf[10];
>> @@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms)
>> if (init_failed) {
>> fprintf(stderr, "Back to %s accelerator.\n", acc->name);
>> }
>> -
>> - return !accel_initialised;
>> }
Have you compiled the code with this path?
Thanks
-Xie
>>
>>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] accel: make configure_accelerator return void
2016-04-14 3:34 ` Changlong Xie
@ 2016-04-14 3:53 ` Wei, Jiangang
0 siblings, 0 replies; 4+ messages in thread
From: Wei, Jiangang @ 2016-04-14 3:53 UTC (permalink / raw)
To: Xie, Changlong
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
peter.maydell@linaro.org
On Thu, 2016-04-14 at 11:34 +0800, Changlong Xie wrote:
> On 04/14/2016 11:19 AM, Wei, Jiangang wrote:
> > ping...
> > Any comments?
> > On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
> >> Return the negated value of accel_initialised is meaningless,
> >> and the caller vl doesn't check it.
> >>
> >> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> >> ---
> >> accel.c | 4 +---
> >> 1 file changed, 1 insertion(+), 3 deletions(-)
> >>
> >> diff --git a/accel.c b/accel.c
> >> index 0510b90..403eb5e 100644
> >> --- a/accel.c
> >> +++ b/accel.c
> >> @@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms)
> >> return ret;
> >> }
> >>
> >> -int configure_accelerator(MachineState *ms)
> >> +void configure_accelerator(MachineState *ms)
> >> {
> >> const char *p;
> >> char buf[10];
> >> @@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms)
> >> if (init_failed) {
> >> fprintf(stderr, "Back to %s accelerator.\n", acc->name);
> >> }
> >> -
> >> - return !accel_initialised;
> >> }
>
> Have you compiled the code with this path?
Thanks for your remind.
I compiled it,
But I forgot to add the changed head file together with accel.c.
I will resend the second version.
Regards,
wei
>
> Thanks
> -Xie
> >>
> >>
> >
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-14 3:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-15 10:07 [Qemu-devel] [PATCH] accel: make configure_accelerator return void Wei Jiangang
2016-04-14 3:19 ` Wei, Jiangang
2016-04-14 3:34 ` Changlong Xie
2016-04-14 3:53 ` Wei, Jiangang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).