From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aqY0f-0007KN-Mk
	for qemu-devel@nongnu.org; Wed, 13 Apr 2016 23:32:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aqY0b-0003od-N0
	for qemu-devel@nongnu.org; Wed, 13 Apr 2016 23:32:01 -0400
Message-ID: <570F0FDB.2080701@cn.fujitsu.com>
Date: Thu, 14 Apr 2016 11:34:51 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1458036463-20180-1-git-send-email-weijg.fnst@cn.fujitsu.com>
	<1460603955.2269.29.camel@localhost>
In-Reply-To: <1460603955.2269.29.camel@localhost>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] accel: make configure_accelerator return
 void
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Wei, Jiangang" <weijg.fnst@cn.fujitsu.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>, "peter.maydell@linaro.org" <peter.maydell@linaro.org>

On 04/14/2016 11:19 AM, Wei, Jiangang wrote:
> ping...
> Any comments?
> On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
>> Return the negated value of accel_initialised is meaningless,
>> and the caller vl doesn't check it.
>>
>> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
>> ---
>>   accel.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/accel.c b/accel.c
>> index 0510b90..403eb5e 100644
>> --- a/accel.c
>> +++ b/accel.c
>> @@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms)
>>       return ret;
>>   }
>>
>> -int configure_accelerator(MachineState *ms)
>> +void configure_accelerator(MachineState *ms)
>>   {
>>       const char *p;
>>       char buf[10];
>> @@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms)
>>       if (init_failed) {
>>           fprintf(stderr, "Back to %s accelerator.\n", acc->name);
>>       }
>> -
>> -    return !accel_initialised;
>>   }

Have you compiled the code with this path?

Thanks
	-Xie
>>
>>
>
>
>