From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqbsz-000496-LF for qemu-devel@nongnu.org; Thu, 14 Apr 2016 03:40:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqbsw-0005T7-Ek for qemu-devel@nongnu.org; Thu, 14 Apr 2016 03:40:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqbsw-0005T1-6u for qemu-devel@nongnu.org; Thu, 14 Apr 2016 03:40:18 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D02B3C05E17F for ; Thu, 14 Apr 2016 07:40:17 +0000 (UTC) References: <1460595118-23127-1-git-send-email-ehabkost@redhat.com> <1460595118-23127-4-git-send-email-ehabkost@redhat.com> From: Marcel Apfelbaum Message-ID: <570F495B.7050304@redhat.com> Date: Thu, 14 Apr 2016 10:40:11 +0300 MIME-Version: 1.0 In-Reply-To: <1460595118-23127-4-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.7 v2 3/3] vl: Replace *_vga_available() functions with class_names field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Paolo Bonzini , "Michael S. Tsirkin" On 04/14/2016 03:51 AM, Eduardo Habkost wrote: > Instead of requiring a separate function for each VGA interface, > just enumerate the corresponding class names on struct > VGAInterfaceInfo. > > Reviewed-by: Eric Blake > Signed-off-by: Eduardo Habkost > --- > vl.c | 70 +++++++++++++++++++++++--------------------------------------------- > 1 file changed, 23 insertions(+), 47 deletions(-) > > diff --git a/vl.c b/vl.c > index b99f22f..36593c9 100644 > --- a/vl.c > +++ b/vl.c > @@ -1979,46 +1979,12 @@ static const QEMUOption qemu_options[] = { > { NULL }, > }; > > -static bool vga_available(void) > -{ > - return object_class_by_name("VGA") || object_class_by_name("isa-vga"); > -} > - > -static bool cirrus_vga_available(void) > -{ > - return object_class_by_name("cirrus-vga") > - || object_class_by_name("isa-cirrus-vga"); > -} > - > -static bool vmware_vga_available(void) > -{ > - return object_class_by_name("vmware-svga"); > -} > - > -static bool qxl_vga_available(void) > -{ > - return object_class_by_name("qxl-vga"); > -} > - > -static bool tcx_vga_available(void) > -{ > - return object_class_by_name("SUNW,tcx"); > -} > - > -static bool cg3_vga_available(void) > -{ > - return object_class_by_name("cgthree"); > -} > - > -static bool virtio_vga_available(void) > -{ > - return object_class_by_name("virtio-vga"); > -} > - > typedef struct VGAInterfaceInfo { > const char *opt_name; /* option name */ > const char *name; /* human-readable name */ > - bool (*available)(void); > + /* Class names indicating that support is available. > + * If no class is specified, the interface is always available */ > + const char *class_names[2]; > } VGAInterfaceInfo; > > static VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = { > @@ -2028,43 +1994,53 @@ static VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = { > [VGA_STD] = { > .opt_name = "std", > .name = "standard VGA", > - .available = vga_available, > + .class_names = { "VGA", "isa-vga" }, > }, > [VGA_CIRRUS] = { > .opt_name = "cirrus", > .name = "Cirrus VGA", > - .available = cirrus_vga_available, > + .class_names = { "cirrus-vga", "isa-cirrus-vga" }, > }, > [VGA_VMWARE] = { > .opt_name = "vmware", > .name = "VMWare SVGA", > - .available = vmware_vga_available, > + .class_names = { "vmware-svga" }, > }, > [VGA_VIRTIO] = { > .opt_name = "virtio", > .name = "Virtio VGA", > - .available = virtio_vga_available, > + .class_names = { "virtio-vga" }, > }, > [VGA_QXL] = { > .opt_name = "qxl", > .name = "QXL VGA", > - .available = qxl_vga_available, > + .class_names = { "qxl-vga" }, > }, > [VGA_TCX] = { > .opt_name = "tcx", > .name = "TCX framebuffer", > - .available = tcx_vga_available, > + .class_names = { "SUNW,tcx" }, > }, > [VGA_CG3] = { > .opt_name = "cg3", > .name = "CG3 framebuffer", > - .available = cg3_vga_available, > + .class_names = { "cgthree" }, > }, > [VGA_XENFB] = { > .opt_name = "xenfb", > }, > }; > > +static bool vga_interface_available(VGAInterfaceType t) > +{ > + VGAInterfaceInfo *ti = &vga_interfaces[t]; > + > + assert(t < VGA_TYPE_MAX); > + return !ti->class_names[0] || > + object_class_by_name(ti->class_names[0]) || > + object_class_by_name(ti->class_names[1]); > +} > + > static void select_vgahw(const char *p) > { > const char *opts; > @@ -2074,7 +2050,7 @@ static void select_vgahw(const char *p) > for (t = 0; t < VGA_TYPE_MAX; t++) { > VGAInterfaceInfo *ti = &vga_interfaces[t]; > if (ti->opt_name && strstart(p, ti->opt_name, &opts)) { > - if (ti->available && !ti->available()) { > + if (!vga_interface_available(t)) { > error_report("%s not available", ti->name); > exit(1); > } > @@ -4492,9 +4468,9 @@ int main(int argc, char **argv, char **envp) > if (default_vga) { > if (machine_class->default_display) { > vga_model = machine_class->default_display; > - } else if (cirrus_vga_available()) { > + } else if (vga_interface_available(VGA_CIRRUS)) { > vga_model = "cirrus"; > - } else if (vga_available()) { > + } else if (vga_interface_available(VGA_STD)) { > vga_model = "std"; > } > } > Reviewed-by: Marcel Apfelbaum Thanks, Marcel