From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqi8U-00015z-Sh for qemu-devel@nongnu.org; Thu, 14 Apr 2016 10:20:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqi8R-0005JL-Jy for qemu-devel@nongnu.org; Thu, 14 Apr 2016 10:20:46 -0400 Received: from chuckie.co.uk ([82.165.15.123]:49966 helo=s16892447.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqi8R-0005J3-DE for qemu-devel@nongnu.org; Thu, 14 Apr 2016 10:20:43 -0400 References: <570F9E3A.4030809@ilande.co.uk> From: Mark Cave-Ayland Message-ID: <570FA717.3000607@ilande.co.uk> Date: Thu, 14 Apr 2016 15:20:07 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2 for-2.6] target-sparc: fix Nucleus quad LDD 128 bit access for windowed registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artyom Tarasenko Cc: qemu-devel On 14/04/16 15:04, Artyom Tarasenko wrote: > Can you please show the output of your checkpatch.pl report? I get: > > $ scripts/checkpatch.pl > 0001-target-sparc-fix-Nucleus-quad-LDD-128-bit-access-for.patch > total: 0 errors, 0 warnings, 25 lines checked > 0001-target-sparc-fix-Nucleus-quad-LDD-128-bit-access-for.patch has no > obvious style problems and is ready for Submission. Okay I've just done an update pull and complete rebuild which fixes the fuzz, but I'm still seeing line ending errors in checkpatch.pl: $ ./scripts/checkpatch.pl /tmp/artyom/\[PATCH\ 1_2\ for-2.6\]\ target-sparc\:\ fix\ Nucleus\ quad\ LDD\ 128\ bit\ access\ for\ windowed\ registers.eml ERROR: DOS line endings #75: FILE: target-sparc/ldst_helper.c:2062: + env->regwptr[rd - 8] = cpu_ldq_nucleus(env, addr);^M$ ERROR: DOS line endings #76: FILE: target-sparc/ldst_helper.c:2063: + env->regwptr[rd + 1 - 8] = cpu_ldq_nucleus(env, addr + 8);^M$ ERROR: DOS line endings #80: FILE: target-sparc/ldst_helper.c:2065: + bswap64s(&env->regwptr[rd - 8]);^M$ ERROR: DOS line endings #81: FILE: target-sparc/ldst_helper.c:2066: + bswap64s(&env->regwptr[rd + 1 - 8]);^M$ ERROR: DOS line endings #91: FILE: target-sparc/ldst_helper.c:2079: + env->regwptr[rd - 8] = helper_ld_asi(env, addr, asi, 4, 0);^M$ ERROR: DOS line endings #92: FILE: target-sparc/ldst_helper.c:2080: + env->regwptr[rd + 1 - 8] = helper_ld_asi(env, addr + 4, asi, 4, 0);^M$ total: 6 errors, 0 warnings, 25 lines checked /tmp/artyom/[PATCH 1_2 for-2.6] target-sparc: fix Nucleus quad LDD 128 bit access for windowed registers.eml has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. and: $ ./scripts/checkpatch.pl /tmp/artyom/\[PATCH\ 2_2\ for-2.6\]\ target-sparc\:\ fix\ Trap\ Based\ Address\ Register\ behavior\ for\ sparc64.eml ERROR: DOS line endings #85: FILE: target-sparc/int64_helper.c:161: + env->pc = env->tbr & ~0x7fffULL;^M$ ERROR: DOS line endings #86: FILE: target-sparc/int64_helper.c:162: + env->pc |= ((env->tl > 1) ? 1 << 14 : 0) | (intno << 5);^M$ total: 2 errors, 0 warnings, 11 lines checked /tmp/artyom/[PATCH 2_2 for-2.6] target-sparc: fix Trap Based Address Register behavior for sparc64.eml has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Possibly the DOS line endings are being added by a mail program? ATB, Mark.