From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
imammedo@redhat.com, mjt@tls.msk.ru, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] smbios: fix typo
Date: Fri, 15 Apr 2016 09:41:38 +0800 [thread overview]
Message-ID: <571046D2.3050003@cn.fujitsu.com> (raw)
In-Reply-To: <5708C7AB.9070309@cn.fujitsu.com>
hi,
this is a typo patch, could I get confirmed?
For your quick reference: System Management BIOS (SMBIOS) Reference
Specification, version 3.0.0. chapter 5.2.1 & 5.2.2
On 04/09/2016 05:13 PM, Cao jin wrote:
> ping?
>
> On 03/29/2016 05:57 PM, Cao jin wrote:
>> sorry mjt, I intended to cc qemu-trivial, now I made it:)
>>
>> On 03/29/2016 05:48 PM, Cao jin wrote:
>>> The spec says: "on paragraph (16-byte) boundaries"
>>>
>>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>>> ---
>>> include/hw/smbios/smbios.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h
>>> index 76ccf70..ba36746 100644
>>> --- a/include/hw/smbios/smbios.h
>>> +++ b/include/hw/smbios/smbios.h
>>> @@ -33,7 +33,7 @@ typedef enum SmbiosEntryPointType {
>>>
>>> /* SMBIOS Entry Point
>>> * There are two types of entry points defined in the SMBIOS
>>> specification
>>> - * (see below). BIOS must place the entry point(s) at a 16-bit-aligned
>>> + * (see below). BIOS must place the entry point(s) at a 16-byte-aligned
>>> * address between 0xf0000 and 0xfffff. Note that either entry point
>>> type
>>> * can be used in a 64-bit target system, except that SMBIOS 2.1
>>> entry point
>>> * only allows the SMBIOS struct table to reside below 4GB address
>>> space.
>>>
>>
>
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-04-15 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 9:48 [Qemu-devel] [PATCH] smbios: fix typo Cao jin
2016-03-29 9:57 ` Cao jin
2016-04-09 9:13 ` Cao jin
2016-04-15 1:41 ` Cao jin [this message]
2016-05-06 18:54 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571046D2.3050003@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).