From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked"
Date: Fri, 15 Apr 2016 12:10:01 +0200 [thread overview]
Message-ID: <5710BDF9.30904@redhat.com> (raw)
In-Reply-To: <1460702609-25971-1-git-send-email-kraxel@redhat.com>
On 15/04/2016 08:43, Gerd Hoffmann wrote:
> This reverts commit 7070e085d490c396f9237c8f10bf8b6e69cd0066.
>
> Commit message claims locking is not needed, but that appears
> to not be true, seabios ehci driver runs into timekeeping problems
> with this, see
> https://bugzilla.redhat.com/show_bug.cgi?id=1322713
I need to look into it further, because for example the same problem
would happen if you moved the PMTIMER to the hypervisor (Xen does this).
But for now this is the right fix, I agree.
Paolo
next prev parent reply other threads:[~2016-04-15 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 6:43 [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked" Gerd Hoffmann
2016-04-15 10:10 ` Paolo Bonzini [this message]
2016-05-02 12:32 ` Gerd Hoffmann
2016-05-02 16:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5710BDF9.30904@redhat.com \
--to=pbonzini@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).