From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar0iJ-0004BG-Kv for qemu-devel@nongnu.org; Fri, 15 Apr 2016 06:11:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ar0iE-0002qE-Ld for qemu-devel@nongnu.org; Fri, 15 Apr 2016 06:10:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar0iE-0002qA-G2 for qemu-devel@nongnu.org; Fri, 15 Apr 2016 06:10:54 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1BCB413A57 for ; Fri, 15 Apr 2016 10:10:54 +0000 (UTC) References: <1460702609-25971-1-git-send-email-kraxel@redhat.com> From: Paolo Bonzini Message-ID: <5710BDF9.30904@redhat.com> Date: Fri, 15 Apr 2016 12:10:01 +0200 MIME-Version: 1.0 In-Reply-To: <1460702609-25971-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Igor Mammedov On 15/04/2016 08:43, Gerd Hoffmann wrote: > This reverts commit 7070e085d490c396f9237c8f10bf8b6e69cd0066. > > Commit message claims locking is not needed, but that appears > to not be true, seabios ehci driver runs into timekeeping problems > with this, see > https://bugzilla.redhat.com/show_bug.cgi?id=1322713 I need to look into it further, because for example the same problem would happen if you moved the PMTIMER to the hypervisor (Xen does this). But for now this is the right fix, I agree. Paolo