From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar0oy-0004Wu-Ad for qemu-devel@nongnu.org; Fri, 15 Apr 2016 06:17:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ar0ou-0004Qr-6W for qemu-devel@nongnu.org; Fri, 15 Apr 2016 06:17:52 -0400 References: <1460710980-9995-1-git-send-email-thuth@redhat.com> From: Mark Cave-Ayland Message-ID: <5710BF9C.6070603@ilande.co.uk> Date: Fri, 15 Apr 2016 11:17:00 +0100 MIME-Version: 1.0 In-Reply-To: <1460710980-9995-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.6] ppc: Fix migration of the XER register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Cc: aik@ozlabs.ru, rth@twiddle.net, agraf@suse.de, qemu-devel@nongnu.org On 15/04/16 10:03, Thomas Huth wrote: > env->xer only holds the lower bits of the XER register nowadays, the > SO, OV and CA bits are stored in separate variables (see the function > cpu_write_xer() for details). Since the migration code currently only > reads the "xer" variable, the upper bits are lost during migration. > Fix it by using cpu_read_xer() instead. > > Signed-off-by: Thomas Huth This looks like the pre_save counterpart to the post_load patch I sent in January (see 6a9620e60cc1b16dba9ee9d9d8cb374e4303c072) so I'm fairly sure this is right. Reviewed-by: Mark Cave-Ayland ATB, Mark.