From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar1D1-0002Ii-8o for qemu-devel@nongnu.org; Fri, 15 Apr 2016 06:42:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ar1D0-00025a-I1 for qemu-devel@nongnu.org; Fri, 15 Apr 2016 06:42:43 -0400 References: <1460465891-6142-1-git-send-email-aleksandar.markovic@rt-rk.com> <1460465891-6142-2-git-send-email-aleksandar.markovic@rt-rk.com> <570FB7C7.7090404@imgtec.com> From: Leon Alrae Message-ID: <5710C577.8080309@imgtec.com> Date: Fri, 15 Apr 2016 11:41:59 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandar Markovic , Aleksandar Markovic , "qemu-devel@nongnu.org" Cc: "proljc@gmail.com" , "kbastian@mail.uni-paderborn.de" , "mark.cave-ayland@ilande.co.uk" , "agraf@suse.de" , "blauwirbel@gmail.com" , "jcmvbkbc@gmail.com" , "qemu-arm@nongnu.org" , "qemu-ppc@nongnu.org" , Petar Jovanovic , "pbonzini@redhat.com" , Miodrag Dinic , "edgar.iglesias@gmail.com" , "gxt@mprc.pku.edu.cn" , "afaerber@suse.de" , "aurelien@aurel32.net" , "rth@twiddle.net" , Maciej Rozycki On 15/04/16 09:48, Aleksandar Markovic wrote: > Agreed. This looks much better, and is simpler and faster. Though, it looks to me that "fst" should be called "status" instead (just not to break consistency throughout SoftFloat library and in other places of assigning name "status" to the last argument of any function if its type is float_status*). If you agree, I am going to replace name "fst" with name "status" in the code that you provided, otherwise as-is. Yes, "status" will be fine. Leon