From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] qdev property: cleanup
Date: Fri, 15 Apr 2016 19:15:17 +0800 [thread overview]
Message-ID: <5710CD45.2080803@cn.fujitsu.com> (raw)
In-Reply-To: <5710BD28.1090301@redhat.com>
On 04/15/2016 06:06 PM, Paolo Bonzini wrote:
>
>> Here's my try rewording the comment (sticking to GTK-Doc conventions
>> even though I dislike them):
>>
>> /**
>> * @qdev_property_add_static:
>> * @dev: Device to add the property to
>> * @prop: The qdev property definition
>> * @err: location to store error information
>> *
>> * Add a static QOM property to @dev for qdev property @prop.
>> * On error, store error in @errp.
>> */
>>
>> Paolo, is it correct?
>
> Yes, it is. You can add also "The type of the QOM property is derived
> from prop->info", which is what Cao Jin really wanted to convey in his
> patch.
>
> Paolo
>
Thanks Paolo for your explanation, much useful info for me:)
I will collect Markus`s rewording and your suggestion into v2 later.
--
Yours Sincerely,
Cao jin
prev parent reply other threads:[~2016-04-15 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 10:14 [Qemu-devel] [PATCH] qdev property: cleanup Cao jin
2016-03-24 11:25 ` Paolo Bonzini
2016-03-25 6:06 ` Cao jin
2016-04-08 11:17 ` Markus Armbruster
2016-04-09 14:25 ` Cao jin
2016-04-12 8:20 ` Markus Armbruster
2016-04-12 12:49 ` Cao jin
2016-04-15 10:06 ` Paolo Bonzini
2016-04-15 11:15 ` Cao jin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5710CD45.2080803@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).