From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar1fr-0007Qq-C6 for qemu-devel@nongnu.org; Fri, 15 Apr 2016 07:12:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ar1fl-0002bt-Hl for qemu-devel@nongnu.org; Fri, 15 Apr 2016 07:12:31 -0400 References: <1458814461-5387-1-git-send-email-caoj.fnst@cn.fujitsu.com> <87mvp4xsbk.fsf@dusky.pond.sub.org> <570910D5.4030705@cn.fujitsu.com> <87a8kzkzlj.fsf@dusky.pond.sub.org> <5710BD28.1090301@redhat.com> From: Cao jin Message-ID: <5710CD45.2080803@cn.fujitsu.com> Date: Fri, 15 Apr 2016 19:15:17 +0800 MIME-Version: 1.0 In-Reply-To: <5710BD28.1090301@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qdev property: cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Markus Armbruster Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, peter.maydell@linaro.org On 04/15/2016 06:06 PM, Paolo Bonzini wrote: > >> Here's my try rewording the comment (sticking to GTK-Doc conventions >> even though I dislike them): >> >> /** >> * @qdev_property_add_static: >> * @dev: Device to add the property to >> * @prop: The qdev property definition >> * @err: location to store error information >> * >> * Add a static QOM property to @dev for qdev property @prop. >> * On error, store error in @errp. >> */ >> >> Paolo, is it correct? > > Yes, it is. You can add also "The type of the QOM property is derived > from prop->info", which is what Cao Jin really wanted to convey in his > patch. > > Paolo > Thanks Paolo for your explanation, much useful info for me:) I will collect Markus`s rewording and your suggestion into v2 later. -- Yours Sincerely, Cao jin