From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ar5WV-0002yB-Bl for qemu-devel@nongnu.org; Fri, 15 Apr 2016 11:19:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ar5WU-0006TD-FT for qemu-devel@nongnu.org; Fri, 15 Apr 2016 11:19:07 -0400 References: <1460731965-28239-1-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <57110663.7030103@redhat.com> Date: Fri, 15 Apr 2016 09:18:59 -0600 MIME-Version: 1.0 In-Reply-To: <1460731965-28239-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bx4MkKXpBxkGA6LQmkgbAqguiTjSK1Iwh" Subject: Re: [Qemu-devel] [PATCH for-2.6 v2] block: Don't ignore flags in blk_{, co, aio}_write_zeroes() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Bx4MkKXpBxkGA6LQmkgbAqguiTjSK1Iwh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/15/2016 08:52 AM, Kevin Wolf wrote: > Commit 57d6a428 neglected to pass the given flags to blk_aio_prwv(), > which broke discard by WRITE SAME for scsi-disk (the UNMAP bit would be= > ignored). >=20 > Commit fc1453cd introduced the same bug for blk_write_zeroes(). This is= > used for 'qemu-img convert' without has_zero_init (e.g. on a block > device) and for preallocation=3Dfalloc in parallels. >=20 > Commit 8896e088 is the version for blk_co_write_zeroes(). This function= > is only used in qemu-io. >=20 > Reported-by: Max Reitz > Signed-off-by: Kevin Wolf > --- >=20 > v2: > - There are two more places with exactly the same bug [Eric] Not just me; Pavel spotted it first: https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg01613.html >=20 > block/block-backend.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Bx4MkKXpBxkGA6LQmkgbAqguiTjSK1Iwh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXEQZjAAoJEKeha0olJ0NqfW0H/AxA5jB5yL8H+VNyx7vqpgjm 1Ya6ZHnhhpiQKL9xWuxKbsEczdVqeo7QOAUO2eKYANh6+IYzBKff8yozAxHGRGth 6Y+pj9P7FjeRQ5hMv+fjZ/QFhzTJxDIrVs2GW1Ym8YEMcUB6+K4NCP5aIaDxpRRN 4Mawy6M6fNwL49xFs7YBi4I8GKJ+EABOO1wRb+/AhAuMtkh6kGThh+wlPTojKFZJ 4KC9tdyP8QEUvrCz+BD6tGe9hP2lc4UX0+kb25RGNRUHZnmpZrQQKqXbKbni/cOM ph4rVTiLd9rQUWDJ7cva3etpYa7E/I5yOGMlvXmdFer1yNi8ETp9PbYZZAQZ4X4= =JQtu -----END PGP SIGNATURE----- --Bx4MkKXpBxkGA6LQmkgbAqguiTjSK1Iwh--