From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54710)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1arO0o-0006Mm-Kb
	for qemu-devel@nongnu.org; Sat, 16 Apr 2016 07:03:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1arO0n-0004SB-MV
	for qemu-devel@nongnu.org; Sat, 16 Apr 2016 07:03:38 -0400
References: <1460690887-32751-1-git-send-email-famz@redhat.com>
	<1460690887-32751-3-git-send-email-famz@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <57121896.7080600@openvz.org>
Date: Sat, 16 Apr 2016 13:48:54 +0300
MIME-Version: 1.0
In-Reply-To: <1460690887-32751-3-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.7 v2 02/17] qapi: Add lock-image in
 blockdev-add options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>, John Snow <jsnow@redhat.com>, qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com

On 04/15/2016 06:27 AM, Fam Zheng wrote:
> To allow overriding the default locking behavior when opening the image.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   qapi/block-core.json | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 1d09079..2913f3e 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2065,6 +2065,9 @@
>   # @detect-zeroes: #optional detect and optimize zero writes (Since 2.1)
>   #                 (default: off)
>   #
> +# @lock-image: #optional whether to lock the image (default: true)
> +#              (Since 2.7)
> +#
>   # Remaining options are determined by the block driver.
>   #
>   # Since: 1.7
> @@ -2082,7 +2085,8 @@
>               '*stats-account-invalid': 'bool',
>               '*stats-account-failed': 'bool',
>               '*stats-intervals': ['int'],
> -            '*detect-zeroes': 'BlockdevDetectZeroesOptions' },
> +            '*detect-zeroes': 'BlockdevDetectZeroesOptions',
> +            '*lock-image': 'bool' },
>     'discriminator': 'driver',
>     'data': {
>         'archipelago':'BlockdevOptionsArchipelago',
should we touch qmp-command.hx?