qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
	qemu devel <qemu-devel@nongnu.org>,
	qemu trivial <qemu-trivial@nongnu.org>,
	Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 1/2] block: fix description of @stats
Date: Sat, 16 Apr 2016 23:59:06 +0200	[thread overview]
Message-ID: <5712B5AA.8000707@redhat.com> (raw)
In-Reply-To: <1460699173-31401-2-git-send-email-xiecl.fnst@cn.fujitsu.com>


[-- Attachment #1.1: Type: text/plain, Size: 1169 bytes --]

On 15.04.2016 07:46, Changlong Xie wrote:
> Qemu does not support "info blockstats" now.

It doesn't? Mine is more than happy to accept that command:

$ x86_64-softmmu/qemu-system-x86_64 -nodefaults \
    -drive if=none,id=drv0,driver=null-co \
    -monitor stdio
QEMU 2.5.90 monitor - type 'help' for more information
(qemu) info blockstats
drv0: rd_bytes=0 wr_bytes=0 rd_operations=0 wr_operations=0
flush_operations=0 wr_total_time_ns=0 rd_total_time_ns=0
flush_total_time_ns=0 rd_merged=0 wr_merged=0 idle_time_ns=0

Max

> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
>  block/block-backend.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/block-backend.c b/block/block-backend.c
> index d74f670..05d5d09 100644
> --- a/block/block-backend.c
> +++ b/block/block-backend.c
> @@ -49,7 +49,7 @@ struct BlockBackend {
>  
>      bool enable_write_cache;
>  
> -    /* I/O stats (display with "info blockstats"). */
> +    /* I/O stats (display with { "execute": "query-blockstats" }). */
>      BlockAcctStats stats;
>  
>      BlockdevOnError on_read_error, on_write_error;
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-04-16 21:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15  5:46 [Qemu-devel] [PATCH v1 0/2] small fix of block/account Changlong Xie
2016-04-15  5:46 ` [Qemu-devel] [PATCH v1 1/2] block: fix description of @stats Changlong Xie
2016-04-16 21:59   ` Max Reitz [this message]
2016-04-18  0:52     ` Changlong Xie
2016-04-15  5:46 ` [Qemu-devel] [PATCH v1 2/2] block: remove redundant stats of block_acct_start() Changlong Xie
2016-04-16 22:11   ` Max Reitz
2016-04-18  0:58     ` Changlong Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5712B5AA.8000707@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=xiecl.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).