From: Thomas Huth <thuth@redhat.com>
To: "Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Fam Zheng" <fam@euphon.net>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
qemu-trivial@nongnu.org, "Magnus Damm" <magnus.damm@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Aleksandar Markovic" <aleksandar.m.mail@gmail.com>
Subject: Re: [PATCH v2 1/8] MAINTAINERS: Mark SH4 hardware orphan
Date: Wed, 10 Jun 2020 13:16:47 +0200 [thread overview]
Message-ID: <5712d31d-93b1-4254-893a-93c2fc7e6502@redhat.com> (raw)
In-Reply-To: <CAHiYmc5UUaSKB6Ee0ds_hj0FBTzt0iLxzNWySt0mcZ9dvtZNyA@mail.gmail.com>
On 10/06/2020 13.08, Aleksandar Markovic wrote:
> пон, 8. јун 2020. у 11:05 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
>>
>> Aurelien Jarno expressed his desire to orphan the SH4 hardware [*]:
>>
>> I don't mind being [...] removed from there.
>> I do not really have time to work on that.
>>
>> Mark the SH4 emulated hardware orphan.
>>
>> Many thanks to Aurelien for his substantial contributions to QEMU,
>> and for maintaining the SH4 hardware for various years!
>>
>> [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg708400.html
>>
>> Message-Id: <20200601214125.GA1924990@aurel32.net>
>> Acked-by: Aurelien Jarno <aurelien@aurel32.net>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>
> The basic idea of the patch (as read from the title and the commit
> message) is good and positive.
>
> The problem is that the patch does something different than the commit
> message says - pretending that it just orphans something. Which is not
> good. Actually, very clumsy and bad.
Aleksandar, could you please stop being so negative? If you've got
issues with a patch, that's fair, but you can then also simply express
your opinion in a professional and constructive way. Calling the work of
someone else "clumsy" is really not something that I want to read on the
qemu-devel mailing list.
Thanks,
Thomas
next prev parent reply other threads:[~2020-06-10 11:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:01 [PATCH v2 0/8] sh4: Mark it orphan in MAINTAINERS & trivial fixes Philippe Mathieu-Daudé
2020-06-08 9:01 ` [PATCH v2 1/8] MAINTAINERS: Mark SH4 hardware orphan Philippe Mathieu-Daudé
2020-06-10 11:08 ` Aleksandar Markovic
2020-06-10 11:16 ` Thomas Huth [this message]
2020-06-10 11:26 ` Aleksandar Markovic
2020-06-10 12:06 ` Philippe Mathieu-Daudé
2020-06-10 12:22 ` Aleksandar Markovic
2020-06-10 20:56 ` Philippe Mathieu-Daudé
2020-06-08 9:01 ` [PATCH v2 2/8] MAINTAINERS: Mark SH4 based R2D & Shix machines orphan Philippe Mathieu-Daudé
2020-06-08 9:48 ` Thomas Huth
2020-06-09 8:41 ` Markus Armbruster
2020-06-09 8:59 ` Magnus Damm
2020-06-09 9:12 ` Philippe Mathieu-Daudé
2020-06-10 9:56 ` Yoshinori Sato
2020-06-10 11:54 ` Aleksandar Markovic
2020-06-08 9:01 ` [PATCH v2 3/8] MAINTAINERS: Mark SH4 TCG target orphan Philippe Mathieu-Daudé
2020-06-09 6:35 ` Aurelien Jarno
2020-06-08 9:01 ` [PATCH v2 4/8] hw/sh4: Use MemoryRegion typedef Philippe Mathieu-Daudé
2020-06-08 10:24 ` Thomas Huth
2020-06-08 9:01 ` [PATCH v2 5/8] hw/sh4: Extract timer definitions to 'hw/timer/tmu012.h' Philippe Mathieu-Daudé
2020-06-08 9:01 ` [PATCH v2 6/8] hw/timer/sh_timer: Remove unused 'qemu/timer.h' include Philippe Mathieu-Daudé
2020-06-08 9:01 ` [PATCH v2 7/8] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image Philippe Mathieu-Daudé
2020-06-08 9:01 ` [PATCH v2 8/8] .travis.yml: Test SH4 " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5712d31d-93b1-4254-893a-93c2fc7e6502@redhat.com \
--to=thuth@redhat.com \
--cc=aleksandar.m.mail@gmail.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=laurent@vivier.eu \
--cc=magnus.damm@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).