Re: [Qemu-devel] [PATCH v1 1/2] block: fix description of @stats

[Changlong Xie <xiecl.fnst@cn.fujitsu.com>]

On 04/17/2016 05:59 AM, Max Reitz wrote:
> On 15.04.2016 07:46, Changlong Xie wrote:
>> Qemu does not support "info blockstats" now.
>
> It doesn't? Mine is more than happy to accept that command:
>
> $ x86_64-softmmu/qemu-system-x86_64 -nodefaults \
>      -drive if=none,id=drv0,driver=null-co \
>      -monitor stdio
> QEMU 2.5.90 monitor - type 'help' for more information
> (qemu) info blockstats
> drv0: rd_bytes=0 wr_bytes=0 rd_operations=0 wr_operations=0
> flush_operations=0 wr_total_time_ns=0 rd_total_time_ns=0
> flush_total_time_ns=0 rd_merged=0 wr_merged=0 idle_time_ns=0
>

It seems i missed something, you are right.

> Max
>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> ---
>>   block/block-backend.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/block-backend.c b/block/block-backend.c
>> index d74f670..05d5d09 100644
>> --- a/block/block-backend.c
>> +++ b/block/block-backend.c
>> @@ -49,7 +49,7 @@ struct BlockBackend {
>>
>>       bool enable_write_cache;
>>
>> -    /* I/O stats (display with "info blockstats"). */
>> +    /* I/O stats (display with { "execute": "query-blockstats" }). */
>>       BlockAcctStats stats;
>>
>>       BlockdevOnError on_read_error, on_write_error;
>>
>
>