[Qemu-devel] [PATCH] ICH9: fix typo

[Qemu-devel] [PATCH] ICH9: fix typo

[Cao jin]

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
 include/hw/i386/ich9.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h
index d04dcdc..abf84ed 100644
--- a/include/hw/i386/ich9.h
+++ b/include/hw/i386/ich9.h
@@ -35,7 +35,7 @@ typedef struct ICH9LPCState {
 
     /* (pci device, intx) -> pirq
      * In real chipset case, the unused slots are never used
-     * as ICH9 supports only D25-D32 irq routing.
+     * as ICH9 supports only D25-D31 irq routing.
      * On the other hand in qemu case, any slot/function can be populated
      * via command line option.
      * So fallback interrupt routing for any devices in any slots is necessary.
-- 
2.1.0

Re: [Qemu-devel] [PATCH] ICH9: fix typo

[Cao jin]

hi mst,
     please ingore this one, I find more small fix like this, I will 
pack all these into one

On 04/18/2016 03:24 PM, Cao jin wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>   include/hw/i386/ich9.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h
> index d04dcdc..abf84ed 100644
> --- a/include/hw/i386/ich9.h
> +++ b/include/hw/i386/ich9.h
> @@ -35,7 +35,7 @@ typedef struct ICH9LPCState {
>
>       /* (pci device, intx) -> pirq
>        * In real chipset case, the unused slots are never used
> -     * as ICH9 supports only D25-D32 irq routing.
> +     * as ICH9 supports only D25-D31 irq routing.
>        * On the other hand in qemu case, any slot/function can be populated
>        * via command line option.
>        * So fallback interrupt routing for any devices in any slots is necessary.
>

-- 
Yours Sincerely,

Cao jin

Re: [Qemu-devel] [PATCH] ICH9: fix typo

[Michael S. Tsirkin]

Pls repost all this after 2.6 is out.
Thanks!

On Mon, Apr 18, 2016 at 03:57:42PM +0800, Cao jin wrote:
> hi mst,
>     please ingore this one, I find more small fix like this, I will pack all
> these into one
> 
> On 04/18/2016 03:24 PM, Cao jin wrote:
> >Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> >---
> >  include/hw/i386/ich9.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h
> >index d04dcdc..abf84ed 100644
> >--- a/include/hw/i386/ich9.h
> >+++ b/include/hw/i386/ich9.h
> >@@ -35,7 +35,7 @@ typedef struct ICH9LPCState {
> >
> >      /* (pci device, intx) -> pirq
> >       * In real chipset case, the unused slots are never used
> >-     * as ICH9 supports only D25-D32 irq routing.
> >+     * as ICH9 supports only D25-D31 irq routing.
> >       * On the other hand in qemu case, any slot/function can be populated
> >       * via command line option.
> >       * So fallback interrupt routing for any devices in any slots is necessary.
> >
> 
> -- 
> Yours Sincerely,
> 
> Cao jin
> 

[Qemu-devel] [PATCH] ICH9: fix typo

[Cao jin]

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
it is 4th attempt to send this patch...
because of it wasn't delivered correctly by eggs.gnu.org

 hw/isa/lpc_ich9.c      | 4 ++--
 include/hw/i386/ich9.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
index 99cd3ba..fafe367 100644
--- a/hw/isa/lpc_ich9.c
+++ b/hw/isa/lpc_ich9.c
@@ -96,8 +96,8 @@ static void ich9_cc_update(ICH9LPCState *lpc)
 
     /*
      * D30: DMI2PCI bridge
-     * It is arbitrarily decided how INTx lines of PCI devicesbehind the bridge
-     * are connected to pirq lines. Our choice is PIRQ[E-H].
+     * It is arbitrarily decided how INTx lines of PCI devices behind
+     * the bridge are connected to pirq lines. Our choice is PIRQ[E-H].
      * INT[A-D] are connected to PIRQ[E-H]
      */
     for (pci_intx = 0; pci_intx < PCI_NUM_PINS; pci_intx++) {
diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h
index d04dcdc..88233c3 100644
--- a/include/hw/i386/ich9.h
+++ b/include/hw/i386/ich9.h
@@ -35,7 +35,7 @@ typedef struct ICH9LPCState {
 
     /* (pci device, intx) -> pirq
      * In real chipset case, the unused slots are never used
-     * as ICH9 supports only D25-D32 irq routing.
+     * as ICH9 supports only D25-D31 irq routing.
      * On the other hand in qemu case, any slot/function can be populated
      * via command line option.
      * So fallback interrupt routing for any devices in any slots is necessary.
@@ -181,7 +181,7 @@ Object *ich9_lpc_find(void);
 #define ICH9_SATA1_DEV                          31
 #define ICH9_SATA1_FUNC                         2
 
-/* D30:F1 power management I/O registers
+/* D31:F0 power management I/O registers
    offset from the address ICH9_LPC_PMBASE */
 
 /* ICH9 LPC PM I/O registers are 128 ports and 128-aligned */
-- 
2.1.0

Re: [Qemu-devel] [PATCH] ICH9: fix typo

[Michael Tokarev]

Applied to -trivial, thanks!

/mjt