From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asX0r-0000ky-AZ for qemu-devel@nongnu.org; Tue, 19 Apr 2016 10:52:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asX0o-0003qP-4O for qemu-devel@nongnu.org; Tue, 19 Apr 2016 10:52:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asX0n-0003qE-TH for qemu-devel@nongnu.org; Tue, 19 Apr 2016 10:52:22 -0400 References: <1461075643-3668-1-git-send-email-liang.z.li@intel.com> <1461075643-3668-6-git-send-email-liang.z.li@intel.com> From: Eric Blake Message-ID: <57164621.8010700@redhat.com> Date: Tue, 19 Apr 2016 08:52:17 -0600 MIME-Version: 1.0 In-Reply-To: <1461075643-3668-6-git-send-email-liang.z.li@intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WVKR95JT83bLKSnM1I0X161qqQQq96oGK" Subject: Re: [Qemu-devel] [PATCH QEMU 5/5] migration: Add the interface for cache drop control List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li , mst@redhat.com, quintela@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com Cc: peter.maydell@linaro.org, james.hogan@imgtec.com, ehabkost@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, armbru@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WVKR95JT83bLKSnM1I0X161qqQQq96oGK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/19/2016 08:20 AM, Liang Li wrote: > Whether drop the cache and drop what kind of cache depend on the Whether to drop the cache, and what kind of cache drop to perform, depend ... > user, add the related qmp and hmp interface to query and set the > cache control value. >=20 > Signed-off-by: Liang Li > --- > +++ b/qapi-schema.json > @@ -612,11 +612,21 @@ > # @x-cpu-throttle-increment: throttle percentage increase each time > # auto-converge detects that migration is n= ot making > # progress. The default value is 10. (Since= 2.5) > +# @x-drop-cache: drop guest's page cache during live migration, the va= lue can > +# be set to 0, 1, 2, 3. 1 means drop the clean page cache, 2 m= eans > +# drop the slab cache, 3 means to drop both clean page cache, = 0 means > +# do not drop any cache. Drop cache can speed up live migratio= n > +# process and reduce the network traffic, the side affect is t= he > +# performance impact to the guest, 1 is the recommended value = for > +# proper balance between speed and performance. The value only= takes > +# affect when the virtio-balloon device are enabled and the gu= est > +# has the related driver. The default value is 0. (Since 2.7) Absolutely not this interface. Make this an enum type, not a raw magic-number integer type, where the user requests "x-drop-cache":"clean", "x-drop-cache":"slab", and so on. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WVKR95JT83bLKSnM1I0X161qqQQq96oGK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXFkYhAAoJEKeha0olJ0NqVJgIAKgnFRUOwoUyXAn1PVxE0kSJ dRGqRFHC5CT4mnObnc4jGEOmQTMVuseURetS0wAx1q/mpR/PlHBTGKMZIty4Y3Lj HJI556cqeIdkZQA0v9bfH8xhq9ZA/WVcOsqSoDvzWLLdti2e2UHDUVQe5HyXg1Tb AIMHMePfYsOU637gD3UFoucJIQXJiAG4eaIEUExpGnlTlalQ1mhj7E3wFjI7x/3l 4j+VnbHv2Oty1vUPxkpSzcWq7yL8ewhzeMaJKtRclSutfjNYoGPUCeOecDtJi1ja Kqm5oqV82ebm1l0s68xx76J5Tk1OazliHHuR/WfK/ajswSHkXtEx2q9aOLoqR6E= =ZwBx -----END PGP SIGNATURE----- --WVKR95JT83bLKSnM1I0X161qqQQq96oGK--