From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1astOz-0002Tx-5b for qemu-devel@nongnu.org; Wed, 20 Apr 2016 10:46:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1astOy-0003YE-7Y for qemu-devel@nongnu.org; Wed, 20 Apr 2016 10:46:49 -0400 References: <1461162766-907-1-git-send-email-kwolf@redhat.com> <1461162766-907-2-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <57179650.1040108@redhat.com> Date: Wed, 20 Apr 2016 16:46:40 +0200 MIME-Version: 1.0 In-Reply-To: <1461162766-907-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="est8CuVpvFfCNwvXLVuVjkQ5ppD9ILd7P" Subject: Re: [Qemu-devel] [PATCH for-2.6 v3 1/3] mirror: Don't extend the last sub-chunk List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --est8CuVpvFfCNwvXLVuVjkQ5ppD9ILd7P Content-Type: multipart/mixed; boundary="f8P9GFvvUniixKMeXW7qQnguTUBnKXxhm" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org Message-ID: <57179650.1040108@redhat.com> Subject: Re: [PATCH for-2.6 v3 1/3] mirror: Don't extend the last sub-chunk References: <1461162766-907-1-git-send-email-kwolf@redhat.com> <1461162766-907-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1461162766-907-2-git-send-email-kwolf@redhat.com> --f8P9GFvvUniixKMeXW7qQnguTUBnKXxhm Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 20.04.2016 16:32, Kevin Wolf wrote: > From: Fam Zheng >=20 > The last sub-chunk is rounded up to the copy granularity in the target > image, resulting in a larger size than the source. >=20 > Add a function to clip the copied sectors to the end. >=20 > This undoes the "wrong" changes to tests/qemu-iotests/109.out in > e5b43573e28. The remaining two offset changes are okay. >=20 > [ kwolf: Use DIV_ROUND_UP to calculate nb_chunks now ] >=20 > Reported-by: Kevin Wolf > Signed-off-by: Fam Zheng > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 19 +++++++++++++++---- > tests/qemu-iotests/109.out | 44 ++++++++++++++++++++++----------------= ------ > 2 files changed, 37 insertions(+), 26 deletions(-) Reviewed-by: Max Reitz --f8P9GFvvUniixKMeXW7qQnguTUBnKXxhm-- --est8CuVpvFfCNwvXLVuVjkQ5ppD9ILd7P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXF5ZQAAoJEDuxQgLoOKytUxQH/3voRAgITfMvR82iiaOqgcqo FRxSbIMWA9CxkYDUGIG+GE+UadBAtCe82PaEIxLz5X1R8RRDa4qYwkVxasmvdsbr UIACL/+LXm8GK9o9eGEWq2dW8gSbkk1Xh/t8lRshVso0nmuqoQPj8yKGjrJB5jJl jId36sLK3jXucRnth5x7/bzPzJiJzVg25MtmKgK7CaTzQOiKOECmqIGpBWRkdB9B qjuajReB1GiE+h8OHFluijv3+sLGvHvoG9ZoqktGJwwWCeqTg285NMim4V3Ef/rt MOzt4EzamMvwUqPMnuTYyzaIQ5JNwmYSyC3dAz9owm6CsZA4pYJj95PRJSe/Rm8= =qihj -----END PGP SIGNATURE----- --est8CuVpvFfCNwvXLVuVjkQ5ppD9ILd7P--