From: Richard Henderson <rth@twiddle.net>
To: "Emilio G. Cota" <cota@braap.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Michael Walle <michael@walle.cc>,
Aurelien Jarno <aurelien@aurel32.net>,
Leon Alrae <leon.alrae@imgtec.com>,
Anthony Green <green@moxielogic.com>, Jia Liu <proljc@gmail.com>,
Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Max Filippov <jcmvbkbc@gmail.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>,
MTTCG Devel <mttcg@greensocs.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags
Date: Wed, 20 Apr 2016 07:52:26 -0700 [thread overview]
Message-ID: <571797AA.2070002@twiddle.net> (raw)
In-Reply-To: <20160419232145.GA19286@flamenco>
On 04/19/2016 04:21 PM, Emilio G. Cota wrote:
> On Thu, Apr 07, 2016 at 13:19:22 -0400, Emilio G. Cota wrote:
>> We are inconsistent with the type of tb->flags: usage varies loosely
>> between int and uint64_t. Settle to uint32_t everywhere, which is
>> superior to both: at least one target (aarch64) uses the most significant
>> bit in the u32, and uint64_t is wasteful.
>>
>> Compile-tested for all targets.
>>
>> Suggested-by: Laurent Desnogues <laurent.desnogues@gmail.com>
>> Suggested-by: Richard Henderson <rth@twiddle.net>
>> Signed-off-by: Emilio G. Cota <cota@braap.org>
>
> Has this patch been queued by anyone? If not, should I resend after
> 2.6 is released?
Sorry for the delay. Queued for 2.7.
r~
prev parent reply other threads:[~2016-04-20 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 17:19 [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags Emilio G. Cota
2016-04-07 17:23 ` Emilio G. Cota
2016-04-07 18:10 ` Richard Henderson
2016-04-07 19:55 ` Edgar E. Iglesias
2016-04-19 23:21 ` Emilio G. Cota
2016-04-20 14:52 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571797AA.2070002@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=cota@braap.org \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent.desnogues@gmail.com \
--cc=leon.alrae@imgtec.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=mst@redhat.com \
--cc=mttcg@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).