From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38945)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1astVO-0000dU-1M
	for qemu-devel@nongnu.org; Wed, 20 Apr 2016 10:53:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1astUW-0005tl-NS
	for qemu-devel@nongnu.org; Wed, 20 Apr 2016 10:53:25 -0400
Sender: Richard Henderson <rth7680@gmail.com>
References: <1460049562-23517-1-git-send-email-cota@braap.org>
	<20160419232145.GA19286@flamenco>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <571797AA.2070002@twiddle.net>
Date: Wed, 20 Apr 2016 07:52:26 -0700
MIME-Version: 1.0
In-Reply-To: <20160419232145.GA19286@flamenco>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Michael Walle <michael@walle.cc>, Aurelien Jarno <aurelien@aurel32.net>, Leon Alrae <leon.alrae@imgtec.com>, Anthony Green <green@moxielogic.com>, Jia Liu <proljc@gmail.com>, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Max Filippov <jcmvbkbc@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, MTTCG Devel <mttcg@greensocs.com>, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 04/19/2016 04:21 PM, Emilio G. Cota wrote:
> On Thu, Apr 07, 2016 at 13:19:22 -0400, Emilio G. Cota wrote:
>> We are inconsistent with the type of tb->flags: usage varies loosely
>> between int and uint64_t. Settle to uint32_t everywhere, which is
>> superior to both: at least one target (aarch64) uses the most significant
>> bit in the u32, and uint64_t is wasteful.
>>
>> Compile-tested for all targets.
>>
>> Suggested-by: Laurent Desnogues <laurent.desnogues@gmail.com>
>> Suggested-by: Richard Henderson <rth@twiddle.net>
>> Signed-off-by: Emilio G. Cota <cota@braap.org>
>
> Has this patch been queued by anyone? If not, should I resend after
> 2.6 is released?

Sorry for the delay.  Queued for 2.7.


r~