From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at7DL-0003jW-Rj for qemu-devel@nongnu.org; Thu, 21 Apr 2016 01:31:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1at7DJ-0007YT-JQ for qemu-devel@nongnu.org; Thu, 21 Apr 2016 01:31:43 -0400 Received: from mail-pf0-x235.google.com ([2607:f8b0:400e:c00::235]:35415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at7DJ-0007Y5-EF for qemu-devel@nongnu.org; Thu, 21 Apr 2016 01:31:41 -0400 Received: by mail-pf0-x235.google.com with SMTP id n1so26260204pfn.2 for ; Wed, 20 Apr 2016 22:31:40 -0700 (PDT) References: <1461119601-4936-1-git-send-email-david@gibson.dropbear.id.au> <1461119601-4936-12-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <571865B5.6000209@ozlabs.ru> Date: Thu, 21 Apr 2016 15:31:33 +1000 MIME-Version: 1.0 In-Reply-To: <1461119601-4936-12-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC for-2.7 11/11] pseries: Remove unused callbacks from sPAPR VIO bus state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , agraf@suse.de, crosthwaite.peter@gmail.com Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 04/20/2016 12:33 PM, David Gibson wrote: > The VIOsPAPRBus structure has some callback pointers in it which aren't > used anywhere in the code. It's not clear exactly why they were there in > the first place, but they certainly have no function now. It is clear - incorrect QOM'fication in 3954d33ab7f82f5a5 when parts of VIOsPAPRDeviceInfo became parts of VIOsPAPRBus, you can adjust the commit log :) Reviewed-by: Alexey Kardashevskiy > > Signed-off-by: David Gibson > --- > include/hw/ppc/spapr_vio.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/hw/ppc/spapr_vio.h b/include/hw/ppc/spapr_vio.h > index ea00c3b..380fe4f 100644 > --- a/include/hw/ppc/spapr_vio.h > +++ b/include/hw/ppc/spapr_vio.h > @@ -75,8 +75,6 @@ struct VIOsPAPRDevice { > struct VIOsPAPRBus { > BusState bus; > uint32_t next_reg; > - int (*init)(VIOsPAPRDevice *dev); > - int (*devnode)(VIOsPAPRDevice *dev, void *fdt, int node_off); > }; > > extern VIOsPAPRBus *spapr_vio_bus_init(void); > -- Alexey