From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at7hz-00020n-Ic for qemu-devel@nongnu.org; Thu, 21 Apr 2016 02:03:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1at7hu-0006CW-Hm for qemu-devel@nongnu.org; Thu, 21 Apr 2016 02:03:23 -0400 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:35074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at7hu-0006CN-Ab for qemu-devel@nongnu.org; Thu, 21 Apr 2016 02:03:18 -0400 Received: by mail-pa0-x234.google.com with SMTP id fs9so25754053pac.2 for ; Wed, 20 Apr 2016 23:03:18 -0700 (PDT) References: <1461119601-4936-1-git-send-email-david@gibson.dropbear.id.au> <1461119601-4936-8-git-send-email-david@gibson.dropbear.id.au> <571861C8.3060702@ozlabs.ru> <20160421055227.GA15176@voom.fritz.box> From: Alexey Kardashevskiy Message-ID: <57186D20.9060002@ozlabs.ru> Date: Thu, 21 Apr 2016 16:03:12 +1000 MIME-Version: 1.0 In-Reply-To: <20160421055227.GA15176@voom.fritz.box> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC for-2.7 07/11] pseries: Move adding of fdt reserve map entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de, crosthwaite.peter@gmail.com On 04/21/2016 03:52 PM, David Gibson wrote: > On Thu, Apr 21, 2016 at 03:14:48PM +1000, Alexey Kardashevskiy wrote: >> On 04/20/2016 12:33 PM, David Gibson wrote: >>> The flattened device tree passed to pseries guests contains a list of >>> reserved memory areas. Currently we construct this list early in >>> spapr_build_fdt() as we sequentially write out the fdt. >>> >>> This will be inconvenient for upcoming cleanups, so this patch moves >>> the reserve map changes to the end of fdt construction. This changes >>> fdt_add_reservemap_entry() calls - which work when writing the fdt >>> sequentially to fdt_add_mem_rsv() calls used when altering the fdt in >>> random access mode. >> >> >> Looks to me like the real reason for this move is that new qdt_setprop_xxx >> API does not support memory reserve map yet. Will it, when? > > Right, and it's not clear that it even should include reserve map > stuff. The reserve map isn't really part of the device tree, it's > just included in the fdt blob for historical and implementation > reasons. > > So I'd prefer to avoid managing a list of reserve entries in qdt - > instead I was thinking of just having a list of reserves passed > straight into qdt_flatten(). > > In the meantime, I'd prefer to defer that design decision. Ok. >> In general, when >> do you plan to get rid of _FDT()? > > Once I've got rid of all the calls to libfdt functions that need error > catching. I meant timeframe :) Like "2.7 release" or so. -- Alexey