From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55708)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1atZ20-0001ul-Vl
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 07:13:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1atZ1v-0002Sw-Vr
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 07:13:52 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:55931 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1atZ1v-0002SS-M4
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 07:13:47 -0400
Message-ID: <571A0766.9030007@kamp.de>
Date: Fri, 22 Apr 2016 13:13:42 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1461320695-31372-1-git-send-email-berrange@redhat.com>
	<1461320695-31372-2-git-send-email-berrange@redhat.com>
	<20160422105928.GC4237@noname.redhat.com>
In-Reply-To: <20160422105928.GC4237@noname.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to
 match -drive with -iscsi opts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Ronnie Sahlberg <ronniesahlberg@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, John Ferlan <jferlan@redhat.com>, Pino Toscano <ptoscano@redhat.com>

Am 22.04.2016 um 12:59 schrieb Kevin Wolf:
> Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben:
>> The iSCSI block driver has ability to lookup various options, in
>> particular authentication info, specified by the separate -iscsi
>> argument. It currently uses the iSCSI IQN as the ID value for this
>> lookup, however, this does not work for common iSCSI IQNs as they
>> contain characters such as ':' which are invalid for use as IDs.
>>
>> This adds an optional 'iscsi-id' parameter to the iSCSI block
>> driver to allow an explicit ID string to be used to reference
>> the -iscsi arg. For example
>>
>>  $QEMU \
>>    -iscsi id=my_initiator,user=fred,password-secret=sec0 \
>>    -drive driver=iscsi,iscsi-id=my_initiator,file=iscsi://somehost/iqn/1
>>
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> I would consider this a new feature rather than a fix appropriate for
> -rc4.

+1

Its rather late and this might have some side effects that are not obvious.
If you need to specify different credentials for different targets you can stil
supply them in the iscsi URL:

iscsi://username:password@host/iqn/0

Peter