From: Richard Henderson <rth@twiddle.net>
To: Sergey Fedorov <sergey.fedorov@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Sergey Fedorov" <serge.fdrv@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 00/11] tcg: Make direct jump patching thread-safe
Date: Sun, 24 Apr 2016 14:36:43 -0700 [thread overview]
Message-ID: <571D3C6B.9050407@twiddle.net> (raw)
In-Reply-To: <1461341333-19646-1-git-send-email-sergey.fedorov@linaro.org>
On 04/22/2016 09:08 AM, Sergey Fedorov wrote:
> When patching translated code for direct block chaining/unchaining,
> modification of concurrently executing code can happen in multi-threaded
> execution. Currently only user-mode is affected. To make direct block patching
> safe, some care must be taken to make sure that the code modification is made
> atomically and concurrently executed code is guaranteed to be consistent.
>
> This patch series fixes all supported TCG targets which use direct patching and
> documents the requirement for direct jump patching be atomic and thread-safe.
>
> The series' tree can be found in a public git repository [1].
>
> [1]https://github.com/sergefdrv/qemu/tree/atomic-tb-patching-2
>
> Summary of changes in v2:
> * Take out mistakingly pulled patches [PATCH 01/11] and [PATCH 02/11]
> * Two new patches to add some handy macros for alignment
> [PATCH v2 01/11] and [PATCH v2 02/11]
> * Use new alignment macros instead of open-coding
> * Use i386 tcg_out_nopn() implementation suggested by Richard Henderson;
> rework alignment checking and gap calculation in [PATCH v2 05/11]
> * Clean up reloc_pc24_atomic() in [PATCH v2 07/11]
> * Use tcg_debug_assert() instead of assert()
> * Use deposit32() in [PATCH v2 09/11]
> * s/atomic_write/atomic_set/ in [PATCH v2 10/11]
> * Minor rewording in [PATCH v2 11/11]
Applied all to tcg-next. I applied the mips one-liner follow-up at the same time.
r~
next prev parent reply other threads:[~2016-04-24 21:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 16:08 [Qemu-devel] [PATCH v2 00/11] tcg: Make direct jump patching thread-safe Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 01/11] include/qemu/osdep.h: Add a macro to check for alignment Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 02/11] include/qemu/osdep.h: Add macros for pointer alignment Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 03/11] tci: Make direct jump patching thread-safe Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 04/11] tcg/ppc: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 05/11] tcg/i386: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 06/11] tcg/s390: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 07/11] tcg/arm: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 08/11] tcg/aarch64: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 09/11] tcg/sparc: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 10/11] tcg/mips: " Sergey Fedorov
2016-04-22 16:47 ` Aurelien Jarno
2016-04-22 16:51 ` Aurelien Jarno
2016-04-22 17:00 ` Sergey Fedorov
2016-04-22 18:27 ` Aurelien Jarno
2016-04-22 16:56 ` Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 11/11] tcg: Note requirement on atomic direct jump patching Sergey Fedorov
2016-04-24 21:36 ` Richard Henderson [this message]
2016-04-25 9:44 ` [Qemu-devel] [PATCH v2 00/11] tcg: Make direct jump patching thread-safe Sergey Fedorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571D3C6B.9050407@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=serge.fdrv@gmail.com \
--cc=sergey.fedorov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).