Re: [Qemu-devel] [PATCH COLO-Frame v16 21/35] qmp event: Add COLO_EXIT event to notify users while exited from COLO

[Hailiang Zhang <zhang.zhanghailiang@huawei.com>]

On 2016/4/22 22:25, Eric Blake wrote:
> On 04/08/2016 12:26 AM, zhanghailiang wrote:
>> If some errors happen during VM's COLO FT stage, it's important to notify the users
>> of this event. Together with 'x_colo_lost_heartbeat', users can intervene in COLO's
>> failover work immediately.
>> If users don't want to get involved in COLO's failover verdict,
>> it is still necessary to notify users that we exited COLO mode.
>>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>
>> +++ b/migration/colo.c
>> @@ -18,6 +18,7 @@
>>   #include "qemu/error-report.h"
>>   #include "qapi/error.h"
>>   #include "migration/failover.h"
>> +#include "qapi-event.h"
>>
>>   /* colo buffer */
>>   #define COLO_BUFFER_BASE_SIZE (4 * 1024 * 1024)
>> @@ -368,6 +369,18 @@ out:
>>       if (local_err) {
>>           error_report_err(local_err);
>>       }
>> +    /*
>> +    * There are only two reasons we can go here, something error happened,
>> +    * Or users triggered failover.
>
> s/something/some/
> s/Or users/or the user/
>
> Otherwise looks fine. As comments are minor fixes,
> Reviewed-by: Eric Blake <eblake@redhat.com>
>

Thanks very much, I'll fix them in next version.

Hailiang