From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aug1G-0000MR-7F for qemu-devel@nongnu.org; Mon, 25 Apr 2016 08:53:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aug1B-0001SY-8V for qemu-devel@nongnu.org; Mon, 25 Apr 2016 08:53:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aug1B-0001ST-3E for qemu-devel@nongnu.org; Mon, 25 Apr 2016 08:53:37 -0400 References: <1461535977-331-1-git-send-email-davidkiarie4@gmail.com> From: Marcel Apfelbaum Message-ID: <571E134B.1090002@redhat.com> Date: Mon, 25 Apr 2016 15:53:31 +0300 MIME-Version: 1.0 In-Reply-To: <1461535977-331-1-git-send-email-davidkiarie4@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V9 0/4] AMD IOMMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Kiarie , qemu-devel@nongnu.org Cc: valentine.sinitsyn@gmail.com, mst@redhat.com, jan.kizska@web.de, imammedo@redhat.com On 04/25/2016 01:12 AM, David Kiarie wrote: > Hi all, > > The current AMD IOMMU patches that fixes Igor's comments. I got rid of structs and instead > added individual integer fields into the table data directly, as suggested. > > I have also got rid of some un-used macros and fixed a few other miscellaneous things. My comments for V8 still stand. I don't see them addressed in this version. Thanks, Marcel > > David Kiarie (4): > hw/i386: Introduce AMD IOMMU > hw/i386: ACPI table for AMD IOMMU > hw/core: Add AMD IOMMU to machine properties > hw/pci-host: Emulate AMD IOMMU > > hw/acpi/aml-build.c | 2 +- > hw/acpi/core.c | 13 - > hw/core/machine.c | 32 +- > hw/i386/Makefile.objs | 1 + > hw/i386/acpi-build.c | 101 ++- > hw/i386/amd_iommu.c | 1426 +++++++++++++++++++++++++++++++++++++++++ > hw/i386/amd_iommu.h | 398 ++++++++++++ > hw/pci-host/q35.c | 21 +- > include/hw/acpi/acpi-defs.h | 14 + > include/hw/acpi/acpi.h | 16 + > include/hw/acpi/aml-build.h | 1 + > include/hw/boards.h | 1 + > include/hw/i386/intel_iommu.h | 1 + > include/hw/pci/pci.h | 2 + > qemu-options.hx | 7 +- > util/qemu-config.c | 8 +- > 16 files changed, 2010 insertions(+), 34 deletions(-) > create mode 100644 hw/i386/amd_iommu.c > create mode 100644 hw/i386/amd_iommu.h >