From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aulsm-0000KG-Az for qemu-devel@nongnu.org; Mon, 25 Apr 2016 15:09:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aulsj-0007ou-24 for qemu-devel@nongnu.org; Mon, 25 Apr 2016 15:09:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aulsi-0007oL-SL for qemu-devel@nongnu.org; Mon, 25 Apr 2016 15:09:16 -0400 References: <1461588373-26486-1-git-send-email-stefanha@redhat.com> From: John Snow Message-ID: <571E6B5A.5070101@redhat.com> Date: Mon, 25 Apr 2016 15:09:14 -0400 MIME-Version: 1.0 In-Reply-To: <1461588373-26486-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.7 0/8] libqos: use standard virtio headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: marc.mari.barcelo@gmail.com, Paolo Bonzini On 04/25/2016 08:46 AM, Stefan Hajnoczi wrote: > This patch series eliminates code duplication in libqos virtio. > include/standard-headers/ contains the Linux virtio header files so we don't > need to define our own version of the structs and constants. > Is that a good idea? I had thought some of the intentional purpose of duplicating the headers was to test the other versions. > Stefan Hajnoczi (8): > libqos: use virtio_ids.h for device ID definitions > libqos: drop duplicated PCI vendor ID definition > libqos: drop duplicated virtio_config.h definitions > libqos: drop duplicated virtio_ring.h bit definitions > libqos: drop duplicated virtio_vring.h structs > libqos: drop duplicated virtio_blk.h definitions > libqos: drop duplicated virtio_scsi.h definitions > libqos: drop duplicated virtio_pci.h definitions > > tests/libqos/virtio-mmio.c | 5 +-- > tests/libqos/virtio-pci.c | 50 ++++++++++++++------------- > tests/libqos/virtio-pci.h | 17 --------- > tests/libqos/virtio.c | 42 +++++++++++----------- > tests/libqos/virtio.h | 73 ++++----------------------------------- > tests/virtio-blk-test.c | 86 ++++++++++++++++++++-------------------------- > tests/virtio-net-test.c | 10 +++--- > tests/virtio-scsi-test.c | 53 +++++++++++----------------- > 8 files changed, 123 insertions(+), 213 deletions(-) >