From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aumV0-0008Ov-1t for qemu-devel@nongnu.org; Mon, 25 Apr 2016 15:48:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aumUy-0006pQ-Nk for qemu-devel@nongnu.org; Mon, 25 Apr 2016 15:48:49 -0400 References: <1461368452-10389-1-git-send-email-eblake@redhat.com> <1461368452-10389-37-git-send-email-eblake@redhat.com> <076E3F4D-5811-4920-880A-80E81664C587@alex.org.uk> <571E6DF5.5080202@redhat.com> <689FD07A-657C-43D2-95FF-3E587844396D@alex.org.uk> From: Eric Blake Message-ID: <571E7495.1080205@redhat.com> Date: Mon, 25 Apr 2016 13:48:37 -0600 MIME-Version: 1.0 In-Reply-To: <689FD07A-657C-43D2-95FF-3E587844396D@alex.org.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4gf0ddWLXp9sqo0SglPw2CWoDJq9pGOcc" Subject: Re: [Qemu-devel] [PATCH v3 36/44] nbd: Improve handling of shutdown requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Kevin Wolf , Paolo Bonzini , "qemu-devel@nongnu.org" , qemu block , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4gf0ddWLXp9sqo0SglPw2CWoDJq9pGOcc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/25/2016 01:40 PM, Alex Bligh wrote: >=20 > On 25 Apr 2016, at 20:20, Eric Blake wrote: >=20 >>>> } else if (fixedNewstyle) { >>> >>> So the above is for NewStyle (not fixedNewStyle)? >> >> The above is for fixedNewStyle when TLS is not negotiated yet; the 'el= se >> if' is for fixedNewStyle after TLS has been negotiated. Prior to TLS,= >> we have to special-case NBD_OPT_ABORT and actually quit. >=20 > OK. fixedNewStyle is defined as a prerequisite for TLS. I'm hoping > nothing in Qemuland ever did non-fixed NewStyle, and assuming that's > the case I would not even support it (certainly it won't play > nicely with all the other stuff you've been doing). Well, there were some last-minute patches that went into the 2.6 candidates that fixed qemu to actually be a fixedNewStyle server (without commit 156f6a10, for example, qemu had the very bug of disconnecting on unknown client options that fixedNewStyle was supposed to prevent). Fortunately, qemu 2.5 is oldstyle only, and qemu 2.6 is the first newstyle server, and I think I got the worst of the interoperability bugs nailed in 2.6, whereas this series is focusing on the feature enhancements for inclusion in 2.7. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4gf0ddWLXp9sqo0SglPw2CWoDJq9pGOcc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXHnSVAAoJEKeha0olJ0NqJjEH/Am0Yd9K3TGUVVqedhj203+j 5P5YVS/n8bX62N+9JuMVxiCWFtfH1HeVyjhz8E+2fpN9RQ50ml5Pl+bkE/9/6han 4AiEU7XtwyVyMefSiozGa16rwSxtL+og9XQB5R1dTp6V1T2UDhPCTRToTpOzZ2Oq Ax4eglr4DUvtqds70pBCe5p0MCpi79LFZGcKEn8w39spsKrAzoKE4FYiVDhZUMTK M9sTjc9cSUdl9M1GUWf2aE+14oYyK5QKdArc0bAuuVt5AkZ9tfKZHPZFRapKPF71 lYIx+6Q5WNQAEyrtiZCNLXKxA4PHqHfYG0vinvVvzWR+TWOz38gSQY8C+3Q0RYc= =8Daa -----END PGP SIGNATURE----- --4gf0ddWLXp9sqo0SglPw2CWoDJq9pGOcc--