From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av0rS-0002Vx-3e for qemu-devel@nongnu.org; Tue, 26 Apr 2016 07:09:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av0rO-0004P7-N4 for qemu-devel@nongnu.org; Tue, 26 Apr 2016 07:08:58 -0400 Message-ID: <571F4C29.8030503@huawei.com> Date: Tue, 26 Apr 2016 19:08:25 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1461568306-14624-1-git-send-email-zhaoshenglong@huawei.com> <1461568306-14624-4-git-send-email-zhaoshenglong@huawei.com> <20160425124232.zdjgvmwrykkrouas@hawk.localdomain> <571E205E.3040508@linaro.org> In-Reply-To: <571E205E.3040508@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao , Andrew Jones Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org, qemu-devel@nongnu.org, peter.huangpeng@huawei.com On 2016/4/25 21:49, Shannon Zhao wrote: > On 2016年04月25日 20:42, Andrew Jones wrote: >> > On Mon, Apr 25, 2016 at 03:11:46PM +0800, Shannon Zhao wrote: >>>> >> > From: Shannon Zhao >>>> >> > >>>> >> > Add PMU IRQ number in ACPI table, then we can use PMU in guest through >>>> >> > ACPI. >>>> >> > >>>> >> > Signed-off-by: Shannon Zhao >>>> >> > Reviewed-by: Andrew Jones >>>> >> > --- >>>> >> > hw/arm/virt-acpi-build.c | 3 +++ >>>> >> > 1 file changed, 3 insertions(+) >> > Question: for testing of this, did you use >> > https://lkml.org/lkml/2016/4/12/755 ? > Actually I didn't test PMU with ACPI since I didn't notice the patch > series you point out and it's very obvious for QEMU changes(adding irq > flag and irq number in GICC). I will have a test later. I have test this patch series using ACPI and guest with the patches you point out. Guest prints below logs and perf works well in guest. [ 0.000000] ACPI-PMU: Assign CPU 0 girq 23 level 0 [ 0.000000] ACPI-PMU: Assign CPU 1 girq 23 level 0 [ 0.000000] ACPI-PMU: Assign CPU 2 girq 23 level 0 [ 0.000000] ACPI-PMU: Assign CPU 3 girq 23 level 0 [...] [ 0.094782] ACPI-PMU: Setting up 4 PMUs for CPU type D07 Thanks, -- Shannon