From: Zhou Jie <zhoujie2011@cn.fujitsu.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/net/opencores_eth: Allocating Large sized arrays to heap
Date: Wed, 27 Apr 2016 09:03:37 +0800 [thread overview]
Message-ID: <57200FE9.3080808@cn.fujitsu.com> (raw)
In-Reply-To: <CAMo8BfL=dAerS7LYPwFCf2xr+Zh4S5KUqFRFEPx-zm=N7GueaQ@mail.gmail.com>
On 2016/4/26 12:12, Max Filippov wrote:
> Hi Zhou,
>
> On Tue, Apr 26, 2016 at 6:35 AM, Zhou Jie <zhoujie2011@cn.fujitsu.com> wrote:
>> open_eth_start_xmit has a huge stack usage of 65536 bytes approx.
>> Moving large arrays to heap to reduce stack usage.
>
> It's an exception, not the rule when full 65536 byte long buffer might be
> needed. Can we do a little better change and not allocate and free this
> buffer every time unconditionally, but instead make buf smaller (1536
> bytes, maximal frame length when HUGEN bit is not set in MODER)
> and only do allocation when that's not enough?
>
Thank you for your suggestion.
I will modify this patch.
Sincerely,
Zhou Jie
--
------------------------------------------------
周潔
Dept 1
No. 6 Wenzhu Road,
Nanjing, 210012, China
TEL：+86+25-86630566-8557
FUJITSU INTERNAL：7998-8557
E-Mail：zhoujie2011@cn.fujitsu.com
------------------------------------------------
prev parent reply other threads:[~2016-04-27 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 3:35 [Qemu-devel] [PATCH] hw/net/opencores_eth: Allocating Large sized arrays to heap Zhou Jie
2016-04-26 4:12 ` Max Filippov
2016-04-27 1:03 ` Zhou Jie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57200FE9.3080808@cn.fujitsu.com \
--to=zhoujie2011@cn.fujitsu.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).