From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avDtS-0002IM-2R for qemu-devel@nongnu.org; Tue, 26 Apr 2016 21:03:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avDtO-00061e-2d for qemu-devel@nongnu.org; Tue, 26 Apr 2016 21:03:54 -0400 References: <1461641713-32720-1-git-send-email-zhoujie2011@cn.fujitsu.com> From: Zhou Jie Message-ID: <57200FE9.3080808@cn.fujitsu.com> Date: Wed, 27 Apr 2016 09:03:37 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] hw/net/opencores_eth: Allocating Large sized arrays to heap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: qemu-devel , QEMU Trivial On 2016/4/26 12:12, Max Filippov wrote: > Hi Zhou, > > On Tue, Apr 26, 2016 at 6:35 AM, Zhou Jie wrote: >> open_eth_start_xmit has a huge stack usage of 65536 bytes approx. >> Moving large arrays to heap to reduce stack usage. > > It's an exception, not the rule when full 65536 byte long buffer might be > needed. Can we do a little better change and not allocate and free this > buffer every time unconditionally, but instead make buf smaller (1536 > bytes, maximal frame length when HUGEN bit is not set in MODER) > and only do allocation when that's not enough? > Thank you for your suggestion. I will modify this patch. Sincerely, Zhou Jie -- ------------------------------------------------ 周潔 Dept 1 No. 6 Wenzhu Road, Nanjing, 210012, China TEL：+86+25-86630566-8557 FUJITSU INTERNAL：7998-8557 E-Mail：zhoujie2011@cn.fujitsu.com ------------------------------------------------