From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51197)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1avPl0-0007Mz-O6
	for qemu-devel@nongnu.org; Wed, 27 Apr 2016 09:43:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1avPkv-0007o4-NB
	for qemu-devel@nongnu.org; Wed, 27 Apr 2016 09:43:58 -0400
Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:37458)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1avPkv-0007nj-Dr
	for qemu-devel@nongnu.org; Wed, 27 Apr 2016 09:43:53 -0400
Received: from localhost
	by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Wed, 27 Apr 2016 14:43:50 +0100
Received: from b06cxnps4075.portsmouth.uk.ibm.com
	(d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3C5381B0806E
	for <qemu-devel@nongnu.org>; Wed, 27 Apr 2016 14:44:34 +0100 (BST)
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com
	[9.149.37.248])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u3RDhkh740239198
	for <qemu-devel@nongnu.org>; Wed, 27 Apr 2016 13:43:46 GMT
Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u3RDhkIt006636
	for <qemu-devel@nongnu.org>; Wed, 27 Apr 2016 09:43:46 -0400
References: <1461597528-9760-1-git-send-email-cornelia.huck@de.ibm.com>
	<1461597528-9760-4-git-send-email-cornelia.huck@de.ibm.com>
From: Christian Borntraeger <borntraeger@de.ibm.com>
Message-ID: <5720C211.2060709@de.ibm.com>
Date: Wed, 27 Apr 2016 15:43:45 +0200
MIME-Version: 1.0
In-Reply-To: <1461597528-9760-4-git-send-email-cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.7 3/9] s390x/ipl: Extend the
 IplParameterBlock struct
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-devel@nongnu.org
Cc: agraf@suse.de, jfrei@linux.vnet.ibm.com, Alexander Yarygin <yarygin@linux.vnet.ibm.com>

On 04/25/2016 05:18 PM, Cornelia Huck wrote:


> +        union {
> +            IplBlockCcw ccw;
> +            IplBlockCcw fcp;

you later fix this up in patch 
 s390x/ipl: Provide ipl parameter block

-            IplBlockCcw fcp;
+            IplBlockFcp fcp;


Maybe just move this hunk to patch 3.