From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avQYF-0004TN-8y for qemu-devel@nongnu.org; Wed, 27 Apr 2016 10:34:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avQYC-0006f6-2m for qemu-devel@nongnu.org; Wed, 27 Apr 2016 10:34:51 -0400 References: <1461750767-23273-1-git-send-email-kwolf@redhat.com> <1461750767-23273-5-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5720CDFF.6090702@redhat.com> Date: Wed, 27 Apr 2016 08:34:39 -0600 MIME-Version: 1.0 In-Reply-To: <1461750767-23273-5-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Hbnp7DmKWF9q6RmLF2ltlr33jnquf7cwg" Subject: Re: [Qemu-devel] [PATCH 04/17] block: Rename bdrv_co_do_preadv/writev to bdrv_co_preadv/writev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: famz@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Hbnp7DmKWF9q6RmLF2ltlr33jnquf7cwg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2016 03:52 AM, Kevin Wolf wrote: > It used to be an internal helper function just for implementing > bdrv_co_do_readv/writev(), but now that it's a public interface, it > deserves a name without "do" in it. >=20 > Signed-off-by: Kevin Wolf > --- > block/block-backend.c | 4 ++-- > block/io.c | 20 ++++++++++---------- > block/raw_bsd.c | 4 ++-- > hw/ide/macio.c | 4 ++-- > include/block/block_int.h | 4 ++-- > 5 files changed, 18 insertions(+), 18 deletions(-) >=20 > @@ -1127,7 +1127,7 @@ static int coroutine_fn bdrv_co_do_readv(BlockDri= verState *bs, > return -EINVAL; > } > =20 > - return bdrv_co_do_preadv(bs, sector_num << BDRV_SECTOR_BITS, > + return bdrv_co_preadv(bs, sector_num << BDRV_SECTOR_BITS, > nb_sectors << BDRV_SECTOR_BITS, qiov, fla= gs); > } Missed alignment. > @@ -1523,7 +1523,7 @@ static int coroutine_fn bdrv_co_do_writev(BlockDr= iverState *bs, > return -EINVAL; > } > =20 > - return bdrv_co_do_pwritev(bs, sector_num << BDRV_SECTOR_BITS, > + return bdrv_co_pwritev(bs, sector_num << BDRV_SECTOR_BITS, > nb_sectors << BDRV_SECTOR_BITS, qiov, fl= ags); > } and again > +++ b/hw/ide/macio.c > @@ -55,8 +55,8 @@ static const int debug_macio =3D 0; > /* > * Unaligned DMA read/write access functions required for OS X/Darwin = which > * don't perform DMA transactions on sector boundaries. These function= s are > - * modelled on bdrv_co_do_preadv()/bdrv_co_do_pwritev() and so should = be > - * easy to remove if the unaligned block APIs are ever exposed. > + * modelled on bdrv_co_preadv()/bdrv_co_pwritev() and so should be eas= y to > + * remove if the unaligned block APIs are ever exposed. > */ Is this comment now stale as a result of your series? > +++ b/include/block/block_int.h > @@ -517,10 +517,10 @@ extern BlockDriver bdrv_qcow2; > */ > void bdrv_setup_io_funcs(BlockDriver *bdrv); > =20 > -int coroutine_fn bdrv_co_do_preadv(BlockDriverState *bs, > +int coroutine_fn bdrv_co_preadv(BlockDriverState *bs, > int64_t offset, unsigned int bytes, QEMUIOVector *qiov, > BdrvRequestFlags flags); > -int coroutine_fn bdrv_co_do_pwritev(BlockDriverState *bs, > +int coroutine_fn bdrv_co_pwritev(BlockDriverState *bs, > int64_t offset, unsigned int bytes, QEMUIOVector *qiov, > BdrvRequestFlags flags); Should alignment be attempted here, while touching it? My comments are minor, so whether or not you make those changes: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Hbnp7DmKWF9q6RmLF2ltlr33jnquf7cwg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXIM3/AAoJEKeha0olJ0NqfroIAK9l91gGtp7aQ69mctoX/2I6 dofgIfU32SWywIdbr4kBf3ekK42YZdsZlb0wouKqQNIwbWrPzR/uB9AOfCj6FGw7 DcEzCQVgNsNW5ebqeg2+8xy14XxMIA91tu8IvuYB1GT2zM4jFE2mPf32/p3WorXm yPpKf7mQLoBcxF+/FmtSN2t39uCF62BWtijjCPERxlxiyNzABaeGaxfDR5gxpc5u boOE5/uczbn7c3Eh4v3KLAtphfntSSgS/GJf7uYsIPwc8mFJ+QBaQ7w8ErVENdbP SR3tILBwPHjacSffLYaC2Azsyv/ST3Tjtoyt7FUSNSC53ZzTSgaNnJsBJu/86Eg= =5E8e -----END PGP SIGNATURE----- --Hbnp7DmKWF9q6RmLF2ltlr33jnquf7cwg--