From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avRkx-0005pi-Cg for qemu-devel@nongnu.org; Wed, 27 Apr 2016 11:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avRkw-00062t-GU for qemu-devel@nongnu.org; Wed, 27 Apr 2016 11:52:03 -0400 References: <1461750767-23273-1-git-send-email-kwolf@redhat.com> <1461750767-23273-7-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5720E01A.1010909@redhat.com> Date: Wed, 27 Apr 2016 09:51:54 -0600 MIME-Version: 1.0 In-Reply-To: <1461750767-23273-7-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="U27hVKk7LuLbvLqWhfPE620ksIPhG9RmX" Subject: Re: [Qemu-devel] [PATCH 06/17] bochs: Implement .bdrv_co_preadv() interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: famz@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U27hVKk7LuLbvLqWhfPE620ksIPhG9RmX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2016 03:52 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/bochs.c | 46 +++++++++++++++++++++++++++++----------------- > 1 file changed, 29 insertions(+), 17 deletions(-) >=20 > static void bochs_close(BlockDriverState *bs) > @@ -267,7 +279,7 @@ static BlockDriver bdrv_bochs =3D { > .instance_size =3D sizeof(BDRVBochsState), > .bdrv_probe =3D bochs_probe, > .bdrv_open =3D bochs_open, > - .bdrv_read =3D bochs_co_read, > + .bdrv_co_preadv =3D bochs_co_preadv, > .bdrv_close =3D bochs_close, > }; Alignment is funky here. I'd rather just get rid of all the extra spaces, if that's easier than having half but not all of the =3D aligned.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --U27hVKk7LuLbvLqWhfPE620ksIPhG9RmX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXIOAaAAoJEKeha0olJ0NqLYQH/A+IfEIcTPmxZ5eemey9JEhE QBuJ0BFzlc+70QAsxVIv0TkBsUOzpS1/CtIcaDJGbsOzFrrbVXh+YN4euYxBYjdY Gc72Xg2iE51LnY+XGpCYvxVZ9pExTvRK+pRicAyLVQDA7jS28eldQnukLZuAtpa6 NRwiR06z/WQRWdkGuCreWdQDeqh7oFVRPizawHIpWzV2YMSZCScjS5hAmrKK2XAE A/QeWSizySynCCdb3JuJLJJeVqTCc1ThVIqfOXD2QZRaM67F3njulKdSPki40SGl Rg9CwIfgi+Ef7h+whHgGbtPSOMHngmKAOlkt/Xfuno14bJknrTAqFjaCHZQ7Qeg= =a0Iv -----END PGP SIGNATURE----- --U27hVKk7LuLbvLqWhfPE620ksIPhG9RmX--