Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]

On 04/28/2016 12:00 PM, Markus Armbruster wrote:
>>> Have you checked Marc-André's work for overlap?  Cc'ing him.
>>
>> yeah, it's conflicting with my work. Unfortunately, since I have been
>> asked to wait since a long time, I am no longer on top of things, nor
>> what I need to wait for. I have the feeling we really want
>> qmp_dispatch() in monitor.c:
>> https://github.com/elmarco/qemu/commit/af4158993088ee2bbf9087c440990880d7943eb1.
>>
>> Eric, I have been waiting for your series to settle for getting back
>> to qapi, but it keeps growing ;) I hope you are familiar with the work
>> I did in the branch so we don't duplicate efforts.
> 
> I'd very much prefer to give precedence to Marc-André's solution.
> 
> I think this patch is in this series just because the previous patch
> notes a redundancy, and promises its cleanup.  What about this:
> 
> * We shelve this patch for now, and s/a later patch/a future patch/ in
>   the previous patch's commit message.
> 
> * We continue to flush Eric's QAPI queue.  If we come to a point where
>   we really want this patch, we insert it, and apologize to Marc-André.
>   But hopefully we come to a point where Marc-André's work fits first!
>   We'll refer to this patch when reviewing his solution, to make sure
>   we're not losing anything.
> 
> Okay?

Sounds good to me :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]