From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avsy6-0005L7-6y for qemu-devel@nongnu.org; Thu, 28 Apr 2016 16:55:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avsy1-00059C-U6 for qemu-devel@nongnu.org; Thu, 28 Apr 2016 16:55:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avsy1-000597-N4 for qemu-devel@nongnu.org; Thu, 28 Apr 2016 16:55:21 -0400 References: <1460977906-25218-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> <1460977906-25218-2-git-send-email-zhangchen.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <572278B6.6010706@redhat.com> Date: Thu, 28 Apr 2016 14:55:18 -0600 MIME-Version: 1.0 In-Reply-To: <1460977906-25218-2-git-send-email-zhangchen.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E4e1N1pCxMKLoCDrmi98Kochg7s0njtSD" Subject: Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , qemu devel , Jason Wang Cc: Li Zhijian , Gui jianfeng , "eddie.dong" , zhanghailiang , "Dr. David Alan Gilbert" , Yang Hongyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E4e1N1pCxMKLoCDrmi98Kochg7s0njtSD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/18/2016 05:11 AM, Zhang Chen wrote: s/initlization/initialization/ in the subject > packet come from primary char indev will be send to > outdev - packet come from secondary char dev will be drop Grammar suggestion: Packets coming from the primary char indev will be sent to outdev; packets coming from the secondary char dev will be dropped > Signed-off-by: Li Zhijian > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > +/* > + * called from the main thread on the primary > + * for get packets s/get/getting/ > +++ b/qemu-options.hx > @@ -3866,6 +3866,12 @@ Dump the network traffic on netdev @var{dev} to = the file specified by > The file format is libpcap, so it can be analyzed with tools such as t= cpdump > or Wireshark. > =20 > +@item -object colo-compare,id=3D@var{id},primary_in=3D@var{chardevid},= secondary_in=3D@var{chardevid}, > +outdev=3D@var{chardevid} > + > +Colo-compare get packet from primary_in@var{chardevid} and secondary_i= n@var{chardevid}, s/get/gets/ > +and output to outdev@var{chardevid}, we can use it with the help of fi= lter-mirror and filter-redirector. s/output/outputs/ Worth any better hints here about _how_ to use it with filter-mirror and filter-redirector, or should the last phrase just be dropped? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E4e1N1pCxMKLoCDrmi98Kochg7s0njtSD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXIni2AAoJEKeha0olJ0Nq1bAH/RqWJ+aHrr75VvrhKJ8/59L8 Ska+RgSsDxBXf6FHDLdgPrnK9gy4HoIzI8POMrmFXWzW5fM7c6hRkVCLD/xC3Cwm WRDRx0YHPROSLunOxAwAEo6IEfCU2GQ0BvjK0N7AGxv5O3VtuFznJB7bc2GRpqfd OVDpeA+w+NTz4Hzu4KLmfO04rQhqj4G+HPJqEj/xh0lZWT5HeQ+vgUOdxanpVyil 4e3TxNMUsFByrwQWWRdHHzhnMU/LSWikWjOrLPRe2iquMu82H1Xwmad+iWvJ34tz L2CsxTu+cGOm+smsv9z3g5fcB9eTB1ealR3OmCqmiCs9wf18/dJZvCiEAmoiv2U= =s4Pk -----END PGP SIGNATURE----- --E4e1N1pCxMKLoCDrmi98Kochg7s0njtSD--