From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avyAM-0006K2-KH for qemu-devel@nongnu.org; Thu, 28 Apr 2016 22:28:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avyAL-0006yZ-Oj for qemu-devel@nongnu.org; Thu, 28 Apr 2016 22:28:26 -0400 References: <1461849406-29743-1-git-send-email-kwolf@redhat.com> <1461849406-29743-8-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5722C6C3.5000505@redhat.com> Date: Thu, 28 Apr 2016 20:28:19 -0600 MIME-Version: 1.0 In-Reply-To: <1461849406-29743-8-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nnuOTA4o4pBlBIVGNeRaOesrAusA5XRnU" Subject: Re: [Qemu-devel] [PATCH v2 07/17] cloop: Implement .bdrv_co_preadv() interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: famz@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nnuOTA4o4pBlBIVGNeRaOesrAusA5XRnU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/28/2016 07:16 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/cloop.c | 38 ++++++++++++++++++++++---------------- > 1 file changed, 22 insertions(+), 16 deletions(-) >=20 > for (i =3D 0; i < nb_sectors; i++) { > + void *data; > uint32_t sector_offset_in_block =3D > ((sector_num + i) % s->sectors_per_block), > block_num =3D (sector_num + i) / s->sectors_per_block; > if (cloop_read_block(bs, block_num) !=3D 0) { > - return -1; > + ret =3D -EIO; > + goto fail; Might want to mention in the commit message that the fix of the return value to use negative errno is intentional. Otherwise, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nnuOTA4o4pBlBIVGNeRaOesrAusA5XRnU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXIsbDAAoJEKeha0olJ0NqywEIAJFV70xlRXITBJQ0uq20w2NM AmtMA93q3Bsj3bO3sX7/5OakxnSN+0Gjpz/dfbmE9WV8CM+2kqE2XkN0HCdOyaDQ JGbOq8hSbdEJuXT27tIbtWIjIccaG0A6aTVYLy3hmM18EPs7Z5l1LMNV3AGZEacF LDtY4vdqPD5NuI/bwER6GGN+6xiMU/MJYcRbwMjx80Pzi7KVsE3R8UeOq4uXWAeK sBiirP52MBWBAwch5OSNoY8e9pDWZHPSeO4eC+z41Ue7qBvw/lzc74rfLE5EQtUq UVM0RiDie24QpDa5XnenCJdThw7h087LqA8CjS173SNFd0Kpteto/9/ACkZEg5A= =7oP6 -----END PGP SIGNATURE----- --nnuOTA4o4pBlBIVGNeRaOesrAusA5XRnU--