From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avzpe-0003Lx-S7 for qemu-devel@nongnu.org; Fri, 29 Apr 2016 00:15:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avzpd-00077n-VR for qemu-devel@nongnu.org; Fri, 29 Apr 2016 00:15:10 -0400 References: <1461898826-24113-1-git-send-email-zhoujie2011@cn.fujitsu.com> From: Eric Blake Message-ID: <5722DFC6.3010308@redhat.com> Date: Thu, 28 Apr 2016 22:15:02 -0600 MIME-Version: 1.0 In-Reply-To: <1461898826-24113-1-git-send-email-zhoujie2011@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NumhFBCSC0n49P6qTxTUgOJa44FqHbRaq" Subject: Re: [Qemu-devel] [PATCH v3] block: always compile-check debug prints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhou Jie , qemu-devel@nongnu.org Cc: jcody@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NumhFBCSC0n49P6qTxTUgOJa44FqHbRaq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/28/2016 09:00 PM, Zhou Jie wrote: > Files with conditional debug statements should ensure that the printf i= s > always compiled. > This prevents bitrot of the format string of the debug statement. Still missing a sentence about the intentional change to use stderr. >=20 > Signed-off-by: Zhou Jie > Reviewed-by: Eric Blake > --- > v1 -> v2: > * Keep the user-visible witness as defined/undefined, > and create a secondary witness as the actual conditional. > * Switch debug output to stderr. You have it here, but anything after the --- separator gets stripped by 'git am', while we want the change to stderr to be documented as part of the permanent commit log. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NumhFBCSC0n49P6qTxTUgOJa44FqHbRaq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXIt/GAAoJEKeha0olJ0NqLCYH/1bDslm3LXIwRS7hJcHzqy8i VcQBG+Rjq3zKUxSZ6DFU03wAV+zsIaNt8KzYd0KMPIGxiTq+VTtwYrGMchrSSTqr AHF6cNCc5baK4bxSd7rTadaJf+ONtP5PC3nosghZ/uk9sGgwegkLbIKjtt01suAz loBkxrkKFaAwzTNswNQHGP7RUKMf+d+QXI3s0ouTinVZGqPFIwg3SKXc+h4tEhMq lwLzQz/WfcsTG2kxLG3TYv1Wgj7Ww6ZTNAwsirI/1YCZr+fwu1YXNOgyA+oadC85 kSw+/5WXJV+Q/TcxI6DRflegeIy1geZusFrzwC1SRUMw9suJndAJZcQFiMPBEww= =UyQU -----END PGP SIGNATURE----- --NumhFBCSC0n49P6qTxTUgOJa44FqHbRaq--