From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw8y4-0005jB-Ho for qemu-devel@nongnu.org; Fri, 29 Apr 2016 10:00:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw8xs-0003Mm-Qk for qemu-devel@nongnu.org; Fri, 29 Apr 2016 10:00:23 -0400 Message-ID: <572368BE.1010203@imgtec.com> Date: Fri, 29 Apr 2016 14:59:26 +0100 From: Leon Alrae MIME-Version: 1.0 References: <1460995422-14373-1-git-send-email-aleksandar.markovic@rt-rk.com> <1460995422-14373-3-git-send-email-aleksandar.markovic@rt-rk.com> In-Reply-To: <1460995422-14373-3-git-send-email-aleksandar.markovic@rt-rk.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 2/9] softfloat: For Mips only, correct default NaN values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandar Markovic Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, proljc@gmail.com, kbastian@mail.uni-paderborn.de, mark.cave-ayland@ilande.co.uk, agraf@suse.de, blauwirbel@gmail.com, jcmvbkbc@gmail.com, aleksandar.markovic@imgtec.com, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, petar.jovanovic@imgtec.com, pbonzini@redhat.com, miodrag.dinic@imgtec.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, afaerber@suse.de, aurelien@aurel32.net, rth@twiddle.net, maciej.rozycki@imgtec.com On 18/04/16 17:03, Aleksandar Markovic wrote: > From: Aleksandar Markovic >=20 > Only for Mips platform, and only for cases when snan_bit_is_one is 0, > correct default NaN values (in their 16-, 32-, and 64-bit flavors). >=20 > For more info, see [1], page 84, Table 6.3 "Value Supplied When a New > Quiet NaN Is Created", and [2], page 52, Table 3.7 "Default NaN > Encodings". >=20 > [1] "MIPS=C2=AE Architecture For Programmers Volume II-A: > The MIPS64=C2=AE Instruction Set Reference Manual", > Imagination Technologies LTD, Revision 6.04, November 13, 2015 >=20 > [2] "MIPS Architecture for Programmers Volume IV-j: > The MIPS32=C2=AE SIMD Architecture Module", > Imagination Technologies LTD, Revision 1.12, February 3, 2016 >=20 > Signed-off-by: Aleksandar Markovic > --- > fpu/softfloat-specialize.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h > index e03a529..093218f 100644 > --- a/fpu/softfloat-specialize.h > +++ b/fpu/softfloat-specialize.h > @@ -97,7 +97,11 @@ float16 float16_default_nan(float_status *status) > if (status->snan_bit_is_one) { > return const_float16(0x7DFF); > } else { > +#if defined(TARGET_MIPS) > + return const_float16(0x7E00); > +#else > return const_float16(0xFE00); > +#endif > } > #endif > } > @@ -116,7 +120,11 @@ float32 float32_default_nan(float_status *status) > if (status->snan_bit_is_one) { > return const_float32(0x7FBFFFFF); > } else { > +#if defined(TARGET_MIPS) > + return const_float32(0x7FC00000); > +#else > return const_float32(0xFFC00000); > +#endif > } > #endif > } > @@ -135,7 +143,11 @@ float64 float64_default_nan(float_status *status) > if (status->snan_bit_is_one) { > return const_float64(LIT64(0x7FF7FFFFFFFFFFFF)); > } else { > +#if defined(TARGET_MIPS) > + return const_float64(LIT64(0x7FF8000000000000)); > +#else > return const_float64(LIT64(0xFFF8000000000000)); > +#endif > } > #endif > } Reviewed-by: Leon Alrae