From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awAMb-0005SD-Ex for qemu-devel@nongnu.org; Fri, 29 Apr 2016 11:29:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awAMP-00046G-Kd for qemu-devel@nongnu.org; Fri, 29 Apr 2016 11:29:48 -0400 References: From: Eric Blake Message-ID: <57237DC1.1040804@redhat.com> Date: Fri, 29 Apr 2016 09:29:05 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6BIBkWxcK6dkU88RiifW1n7K3uv5jl17Q" Subject: Re: [Qemu-devel] [PATCH v9 07/11] block: Add QMP support for streaming to an intermediate layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Max Reitz , Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6BIBkWxcK6dkU88RiifW1n7K3uv5jl17Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/04/2016 07:43 AM, Alberto Garcia wrote: > This patch makes the 'device' parameter of the 'block-stream' command > accept a node name as well as a device name. >=20 > In addition to that, operation blockers will be checked in all > intermediate nodes between the top and the base node. >=20 > Since qmp_block_stream() now uses the error from bdrv_lookup_bs() and > no longer returns DeviceNotFound, iotest 030 is updated to expect > GenericError instead. >=20 > Signed-off-by: Alberto Garcia > --- > +++ b/qapi/block-core.json > @@ -1405,6 +1405,10 @@ Context: block-stream > # with query-block-jobs. The operation can be stopped before it has c= ompleted > # using the block-job-cancel command. > # > +# The node that receives the data is called the top image, can be loca= ted > +# in any part of the whole chain and can be specified using its device= > +# or node name. > +# "any part of the whole chain" feels fishy - it has to be ABOVE the base file. That is, in a chain A <- B <- C <- D <- E, if I want to set B as the base, then the top has to be C, D, or E (but not A). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6BIBkWxcK6dkU88RiifW1n7K3uv5jl17Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXI33BAAoJEKeha0olJ0NqsesIAJJxLeyk705EkSYjg1ddMRQL v4OSVWtv8AaTI1YT6mhged9bG+TYam4BBLHcmFUyQbgB3NKdKuxNM+Deb27v1UTa rE8UcLAiI7lpqEnQcgT8eVw4Hf/chc/Yb9pZLh2l22lF105pcvoUJfg5Sc+icoAo ksp5BbMOIqhwEt0ZZrcfgRLLVvzzubEmqnkONbhNS7gNJVmceQz5pvjQo6Xk25Ji I54EVcxgQi1PE8SzvvznZ/Q//nQkjgh50LUFusScpAY9XN8iTlWHBGgudeb9EnuB 5K6uIDLcfIH+gJ420xUWdAYKpICLpLJssX13WCqZdps9nIJmlvLCYryR4/1DVBw= =ARh/ -----END PGP SIGNATURE----- --6BIBkWxcK6dkU88RiifW1n7K3uv5jl17Q--