From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1axHlq-0007V3-2G
	for qemu-devel@nongnu.org; Mon, 02 May 2016 13:36:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1axHle-0007Cd-6f
	for qemu-devel@nongnu.org; Mon, 02 May 2016 13:36:28 -0400
Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]:35185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1axHlc-00077w-DI
	for qemu-devel@nongnu.org; Mon, 02 May 2016 13:36:22 -0400
Received: by mail-lf0-x22e.google.com with SMTP id j8so63888808lfd.2
	for <qemu-devel@nongnu.org>; Mon, 02 May 2016 10:36:05 -0700 (PDT)
References: <1462138032-3748-1-git-send-email-sergey.fedorov@linaro.org>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <57279000.2080906@gmail.com>
Date: Mon, 2 May 2016 20:36:00 +0300
MIME-Version: 1.0
In-Reply-To: <1462138032-3748-1-git-send-email-sergey.fedorov@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fixup! tcg/mips: Make direct jump patching
 thread-safe
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <sergey.fedorov@linaro.org>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

On 02/05/16 00:27, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>

Please ignore this patch, the correct one is v2.

Kind regards,
Sergey

> ---
>
>  tcg/mips/tcg-target.inc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c
> index b0440b9c5a79..b514cd7114d2 100644
> --- a/tcg/mips/tcg-target.inc.c
> +++ b/tcg/mips/tcg-target.inc.c
> @@ -1885,6 +1885,6 @@ static void tcg_target_init(TCGContext *s)
>  
>  void tb_set_jmp_target1(uintptr_t jmp_addr, uintptr_t addr)
>  {
> -    atomic_set(ptr, deposit32(OPC_J, 0, 26, addr >> 2));
> +    atomic_set(jmp_addr, deposit32(OPC_J, 0, 26, addr >> 2));
>      flush_icache_range(jmp_addr, jmp_addr + 4);
>  }