From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axaks-0004Y0-Mi for qemu-devel@nongnu.org; Tue, 03 May 2016 09:52:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axakg-00044Y-FN for qemu-devel@nongnu.org; Tue, 03 May 2016 09:52:45 -0400 References: <1459967330-4573-1-git-send-email-mreitz@redhat.com> From: Max Reitz Message-ID: <5728ACFF.6010000@redhat.com> Date: Tue, 3 May 2016 15:51:59 +0200 MIME-Version: 1.0 In-Reply-To: <1459967330-4573-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WKKjh4niMsRPpXJMQFwt1x4NI2I5ecMcb" Subject: Re: [Qemu-devel] [PATCH v3 for-2.7 00/14] qapi: Allow blockdev-add for NBD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Paolo Bonzini , Eric Blake , "Daniel P . Berrange" , Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WKKjh4niMsRPpXJMQFwt1x4NI2I5ecMcb Content-Type: multipart/mixed; boundary="xKvUQoTBrJQDGpsdrmck5c9bWbmFWb3Ed" From: Max Reitz To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Paolo Bonzini , Eric Blake , "Daniel P . Berrange" , Markus Armbruster , Luiz Capitulino Message-ID: <5728ACFF.6010000@redhat.com> Subject: Re: [PATCH v3 for-2.7 00/14] qapi: Allow blockdev-add for NBD References: <1459967330-4573-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1459967330-4573-1-git-send-email-mreitz@redhat.com> --xKvUQoTBrJQDGpsdrmck5c9bWbmFWb3Ed Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 06.04.2016 20:28, Max Reitz wrote: > Turns out NBD is not so simple to do if you do it right. Anyway, this > series adds blockdev-add support for NBD clients. >=20 > Patch 1 adds a QDict function which I needed in later NBD patches for > handling legacy options (move "host" to "address.data.host" etc.). >=20 > Patches 2, 3, 4, and 5 are minor patches with no functional relation to= > this series, other than later patches will touch the code they touch, > too. >=20 > Patches 6 and 7 prepare the code for the addition of a new option > prefix, which is "address.". >=20 > Patch 8 makes the NBD client accept a SocketAddress under the "address"= > option (or rather, a flattened SocketAddress QDict with its keys > prefixed by "address."). The old options "host", "port", and "path" are= > supported as legacy options and translated to the respective > SocketAddress representation. >=20 > Patch 9 drops usage of "host", "port", and "path" outside of > nbd_has_filename_options_conflict(), > nbd_process_legacy_socket_options(), and nbd_refresh_filename(), making= > those options nothing but legacy. >=20 > Patch 10, the goal of this series, is again not very complicated. >=20 > Patches 11, 12, and 13 are required for the iotest added in patch 16. I= t > will invoke qemu-nbd, so patch 13 is required. Besides qemu-nbd, it wil= l > launch an NBD server VM concurrently to the client VM, which is why > patch 14 is required. And finally, it will test whether we can add an > NBD BDS by passing it a file descriptor, which patch 15 is needed for > (so we use the socket_scm_helper to pass sockets to qemu). >=20 > Patch 14 then adds the iotest for NBD's blockdev-add interface. >=20 >=20 > *** This series requires Daniel's qdict_crumple() function (from his > "Provide a QOM-based authorization API" series). *** >=20 >=20 > v2: > - Dropped patches 2 and 3; use Daniel's qdict_crumple() instead. > - Patch 7: Not sure why the diff differs, seems functionally like the > same patch to me. Maybe git changed something about its default diff > algorithm. > - Patch 8: Use qdict_crumple() instead of qdict_unflatten() > - Patch 10: Rebase conflicts Ping --xKvUQoTBrJQDGpsdrmck5c9bWbmFWb3Ed-- --WKKjh4niMsRPpXJMQFwt1x4NI2I5ecMcb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXKKz/AAoJEDuxQgLoOKytOqYIAIFAqvAxJtckSI+UIKq+rMUW /Qw3ZF5T2e1bz8lH78HU4F2lY4sW61A98W0944s8x3Tzw3vlWEpljAXWsYh8lj6X OAWy7fCR/LsGfqQ2dSRvAr6S5l0FhNexsrXtup4qfum3cqBMPgncbZ44TDEv0bIP imqVdQ5zAkOatNM4ItPU+2nuWoBLUmWHwfVTrIGU3S8uq6DNqmitPFOUhNS5ZQlN CGNo0Q0LUk7FlYMkHQoGyBmcddHpJEAQYpSTaKCjddhDeCMKVEdEBFaOnKm+ETbI bkLbz0b+f5MuT8Vh/gfIqQyXOCT68tg84+Zb5qtkHzMqFG0aTX/TJ8RHDV0BO14= =+X3H -----END PGP SIGNATURE----- --WKKjh4niMsRPpXJMQFwt1x4NI2I5ecMcb--