From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40165)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1axbRS-0008Kn-I1
	for qemu-devel@nongnu.org; Tue, 03 May 2016 10:36:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1axbRG-0001aF-FG
	for qemu-devel@nongnu.org; Tue, 03 May 2016 10:36:45 -0400
Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:33966)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1axbRF-0001TG-4v
	for qemu-devel@nongnu.org; Tue, 03 May 2016 10:36:38 -0400
Received: by mail-lf0-x22d.google.com with SMTP id m64so24342281lfd.1
	for <qemu-devel@nongnu.org>; Tue, 03 May 2016 07:36:23 -0700 (PDT)
References: <1462286050-21778-1-git-send-email-sergey.fedorov@linaro.org>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <5728B761.60605@gmail.com>
Date: Tue, 3 May 2016 17:36:17 +0300
MIME-Version: 1.0
In-Reply-To: <1462286050-21778-1-git-send-email-sergey.fedorov@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Remove relic orphaned comment
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <sergey.fedorov@linaro.org>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Sergey Fedorov <serge.fedorov@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Richard Henderson <rth@twiddle.net>

On 03/05/16 17:34, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> This comment should have been deleted by commit 0ac087f1f3ae ("removed
> unused code") but somehow it is still here. There's no point to keep it.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <serge.fedorov@linaro.org>

Sorry, should be:

	Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>

Also, this patch is based on a commit:
    3c712db2c10b ("cpu-exec: Move TB chaining into tb_find_fast()")
from:
    git://github.com/rth7680/qemu.git tcg-next

Kind regards,
Sergey

> ---
>  cpu-exec.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index d43d5ae729b6..d55faa5114c7 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -582,8 +582,6 @@ int cpu_exec(CPUState *cpu)
>                  /* Try to align the host and virtual clocks
>                     if the guest is in advance */
>                  align_clocks(&sc, cpu);
> -                /* reset soft MMU for next block (it can currently
> -                   only be set by a memory fault) */
>              } /* for(;;) */
>          } else {
>  #if defined(__clang__) || !QEMU_GNUC_PREREQ(4, 6)